[PATCH v3 5/5] usb: gadget: atmel_usba_udc: add missing ret value check

From	Robert Baldyga <r.baldyga@samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH v3 5/5] usb: gadget: atmel_usba_udc: add missing ret value check
Date	2015-07-13 11:10 +0200
Message-ID	<pLHUm-3aG-9@gated-at.bofh.it> (permalink)
References	<pLHUm-3aG-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Add missing return value check. In case of error print debug message
and return error code.

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
---
 drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 4095cce0..37d414e 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
@@ -1989,6 +1989,10 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
 		ep->can_isoc = of_property_read_bool(pp, "atmel,can-isoc");
 
 		ret = of_property_read_string(pp, "name", &name);
+		if (ret) {
+			dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret);
+			goto err;
+		}
 		ep->ep.name = name;
 
 		ep->ep_regs = udc->regs + USBA_EPT_BASE(i);
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v3 5/5] usb: gadget: atmel_usba_udc: add missing ret value check Robert Baldyga <r.baldyga@samsung.com> - 2015-07-13 11:10 +0200

csiph-web