Re: [PATCH] w1: Use module_pci_driver

From	Evgeniy Polyakov <zbr@ioremap.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] w1: Use module_pci_driver
Date	2015-07-11 17:00 +0200
Message-ID	<pL4pY-4oi-25@gated-at.bofh.it> (permalink)
References	<pJv1g-2ba-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi everyone

Patch looks good to me, thank you
Greg, please pull it into your tree

Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

07.07.2015, 09:55, "Vaishali Thakkar" <vthakkar1994@gmail.com>:
> Use module_pci_driver for drivers whose init and exit functions
> only register and unregister, respectively.

> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> ---
>  drivers/w1/masters/matrox_w1.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/w1/masters/matrox_w1.c b/drivers/w1/masters/matrox_w1.c
> index d8667b0..684bc9d 100644
> --- a/drivers/w1/masters/matrox_w1.c
> +++ b/drivers/w1/masters/matrox_w1.c
> @@ -232,16 +232,4 @@ static void matrox_w1_remove(struct pci_dev *pdev)
>          }
>          kfree(dev);
>  }
> -
> -static int __init matrox_w1_init(void)
> -{
> - return pci_register_driver(&matrox_w1_pci_driver);
> -}
> -
> -static void __exit matrox_w1_fini(void)
> -{
> - pci_unregister_driver(&matrox_w1_pci_driver);
> -}
> -
> -module_init(matrox_w1_init);
> -module_exit(matrox_w1_fini);
> +module_pci_driver(matrox_w1_pci_driver);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] w1: Use module_pci_driver Evgeniy Polyakov <zbr@ioremap.net> - 2015-07-11 17:00 +0200

csiph-web