Re: [PATCH] w1: Drop owner assignment from i2c_driver

From	Evgeniy Polyakov <zbr@ioremap.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] w1: Drop owner assignment from i2c_driver
Date	2015-07-11 17:00 +0200
Message-ID	<pL4pY-4oi-23@gated-at.bofh.it> (permalink)
References	<pKA8y-2kF-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Krzysztof

Patch looks good to me, thank you.
Greg, please pull it into your tree.

Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

10.07.2015, 09:38, "Krzysztof Kozlowski" <k.kozlowski@samsung.com>:
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
>  drivers/w1/masters/ds2482.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c
> index a674409edfb3..b05e8fefbabd 100644
> --- a/drivers/w1/masters/ds2482.c
> +++ b/drivers/w1/masters/ds2482.c
> @@ -97,7 +97,6 @@ MODULE_DEVICE_TABLE(i2c, ds2482_id);
>
>  static struct i2c_driver ds2482_driver = {
>          .driver = {
> - .owner = THIS_MODULE,
>                  .name = "ds2482",
>          },
>          .probe = ds2482_probe,
> --
> 1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] w1: Drop owner assignment from i2c_driver Evgeniy Polyakov <zbr@ioremap.net> - 2015-07-11 17:00 +0200

csiph-web