Re: [PATCH] cpufreq: Initialize the governor again while restoring policy

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cpufreq: Initialize the governor again while restoring policy
Date	Fri, 10 Jul 2015 05:40:01 +0200
Message-ID	<pKxkl-Ax-9@gated-at.bofh.it> (permalink)
References	<pJQyK-7f0-15@gated-at.bofh.it> <pK7zA-1u4-5@gated-at.bofh.it> <pKcpA-4vS-17@gated-at.bofh.it> <pKtA6-6FG-9@gated-at.bofh.it>
X-Original-To	"Rafael J. Wysocki" <rjw@rjwysocki.net>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=G3M8vBLUPiwiTvOxQ/swQwn0nvF5ES4+Q/cnwZPsfy0=; b=mSA9vyErzyMI8Zlz3SIb5gtcpIzcks6le4VVTrjRk3vJIjln7JwtInvNNEbpv0w2G0 ccd2HIIAF56AoQ+LeijdTV0FO4c36EMcjuKG44DUAjmDUkSkxHSOxYjzNjjt63AH+w8S g7Mj/YeUrzSMTGHcM4ytqHirKKRSQq82ye/3vw8cg8JhlnAaLDwRahzHTDAMQfmDw/tX 0mFEqGZ5phtCOpM8R51r2bh3Wvf9T0I+PtP0H7SGeM+MAfxu9NP6oncUwg8qtaK4N4eq rHH29b70kJy0bJ92+ermpIBdZrd8SmQSXzf5eoIjqXpuqMeXuOAoE51ZXwuo0JOW2R9g IWQw==
X-Gm-Message-State	ALoCoQmjNAa1zF4K6YS5fAvBlC3hudXHzfmSZjkxAr4PizkJSEzvPoVDrfJf4ljD5fNO+fHohCc+
MIME-Version	1.0
X-Received	by 10.52.245.8 with SMTP id xk8mr17339816vdc.63.1436499532035; Thu, 09 Jul 2015 20:38:52 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	16
Organization	linux.* mail to news gateway
X-Original-Cc	Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, Pi-Cheng Chen <pi-cheng.chen@linaro.org>, "Jon Medhurst (Tixy)" <tixy@linaro.org>, open list <linux-kernel@vger.kernel.org>, Steven Rostedt <rostedt@goodmis.org>
X-Original-Date	Fri, 10 Jul 2015 09:08:51 +0530
X-Original-Message-ID	<CAKohpomko4bnMN0SuqW8BAk6MUAyUNnFAWV4nmZNo6=_PS6JbA@mail.gmail.com>
X-Original-References	<f428ecb0927075b25cf7e2ea5fb00eab3d254fdd.1436333568.git.viresh.kumar@linaro.org> <3814282.YWYCHNROVv@vostro.rjw.lan> <20150709051024.GJ1805@linux> <5369372.r4v2a9W8l1@vostro.rjw.lan>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1181189

Show key headers only | View raw

On 10 July 2015 at 05:35, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:

>> - Because governors matched, we skip governor initialization and return
>>   after calling __cpufreq_governor(CPUFREQ_GOV_LIMITS).
>
> But this sounds fragile in principle.  What's the benefit from skipping the
> governor initialization in that case?

So this is the case where we have changed some property of the governor,
and the governor is already initialised. We need to exit the earlier governor
and initialize the new one only when the governor is actually switched.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] cpufreq: Initialize the governor again while restoring policy "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-07-09 02:10 +0200
  Re: [PATCH] cpufreq: Initialize the governor again while restoring policy Viresh Kumar <viresh.kumar@linaro.org> - 2015-07-10 05:40 +0200

csiph-web