Re: [PATCH] cpufreq: Initialize the governor again while restoring policy

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cpufreq: Initialize the governor again while restoring policy
Date	2015-07-10 05:40 +0200
Message-ID	<pKxkl-Ax-9@gated-at.bofh.it> (permalink)
References	<pJQyK-7f0-15@gated-at.bofh.it> <pK7zA-1u4-5@gated-at.bofh.it> <pKcpA-4vS-17@gated-at.bofh.it> <pKtA6-6FG-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10 July 2015 at 05:35, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:

>> - Because governors matched, we skip governor initialization and return
>>   after calling __cpufreq_governor(CPUFREQ_GOV_LIMITS).
>
> But this sounds fragile in principle.  What's the benefit from skipping the
> governor initialization in that case?

So this is the case where we have changed some property of the governor,
and the governor is already initialised. We need to exit the earlier governor
and initialize the new one only when the governor is actually switched.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] cpufreq: Initialize the governor again while restoring policy "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-07-09 02:10 +0200
  Re: [PATCH] cpufreq: Initialize the governor again while restoring policy Viresh Kumar <viresh.kumar@linaro.org> - 2015-07-10 05:40 +0200

csiph-web