Re: [RFC][PATCH] fs: Prevent syncing frozen file system

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Dave Chinner <david@fromorbit.com>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH] fs: Prevent syncing frozen file system
Date	Fri, 10 Jul 2015 02:50:01 +0200
Message-ID	<pKuFP-7if-9@gated-at.bofh.it> (permalink)
References	<pKo7o-37J-15@gated-at.bofh.it> <pKtJL-6Ja-17@gated-at.bofh.it>
X-Original-To	Lukas Czerner <lczerner@redhat.com>
X-Ironport-Anti-Spam-Filtered	true
X-Ironport-Anti-Spam-Result	A2AuDAALFp9VPLC2LXlbgxJUYIZOogcMAQEBAQEBBpQthXkEAgKBVE0BAQEBAQEHAQEBAUABP4QkAQEEJxMcIxAIAw4KCSUPBSUDBxoTiC3PKgEBCAIgGIYFhS6FBgeEKwEElC2EZ4cYmGiBCYMqLDGCSwEBAQ
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	35
Organization	linux.* mail to news gateway
X-Original-Cc	viro@ZenIV.linux.org.uk, bfields@fieldses.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
X-Original-Date	Fri, 10 Jul 2015 10:49:21 +1000
X-Original-Message-ID	<20150710004921.GJ3902@dastard>
X-Original-References	<1436463945-12556-1-git-send-email-lczerner@redhat.com> <20150709234012.GI3902@dastard>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1181142

Show key headers only | View raw

On Fri, Jul 10, 2015 at 09:40:12AM +1000, Dave Chinner wrote:
> On Thu, Jul 09, 2015 at 07:45:45PM +0200, Lukas Czerner wrote:
> > Currently we can end up in a deadlock because of broken
> > sb_start_write -> s_umount ordering.
> > 
> > The race goes like this:
> > 
> >  - write the file
> >  - unlink the file - final_iput will not be calles as file is opened
> >  - freeze the file system
> >  - Now simultaneously close the file and call sync (or syncfs on that
> >    particular file system). Sync will get to wait_sb_inodes() where it will
> >    grab the referece to the inode (__iget()) and later to call iput().
> 
> This problem goes away with the sync scalability patchset that josef
> has been trying to get merged:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git superblock-scaling
> 
> That patchset removes the full sb inodes list walk in
> wait_sb_inodes() and replaces it with a walk of inodes cleaned
> during the sync, which will be an empty list in the case of sync
> running on an empty filesystem. This commit does the work:

s/empty/frozen

-Dave.
-- 
Dave Chinner
david@fromorbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [RFC][PATCH] fs: Prevent syncing frozen file system Dave Chinner <david@fromorbit.com> - 2015-07-10 02:50 +0200

csiph-web