Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1181142 > unrolled thread
| Started by | Dave Chinner <david@fromorbit.com> |
|---|---|
| First post | 2015-07-10 02:50 +0200 |
| Last post | 2015-07-10 02:50 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RFC][PATCH] fs: Prevent syncing frozen file system Dave Chinner <david@fromorbit.com> - 2015-07-10 02:50 +0200
| From | Dave Chinner <david@fromorbit.com> |
|---|---|
| Date | 2015-07-10 02:50 +0200 |
| Subject | Re: [RFC][PATCH] fs: Prevent syncing frozen file system |
| Message-ID | <pKuFP-7if-9@gated-at.bofh.it> |
On Fri, Jul 10, 2015 at 09:40:12AM +1000, Dave Chinner wrote: > On Thu, Jul 09, 2015 at 07:45:45PM +0200, Lukas Czerner wrote: > > Currently we can end up in a deadlock because of broken > > sb_start_write -> s_umount ordering. > > > > The race goes like this: > > > > - write the file > > - unlink the file - final_iput will not be calles as file is opened > > - freeze the file system > > - Now simultaneously close the file and call sync (or syncfs on that > > particular file system). Sync will get to wait_sb_inodes() where it will > > grab the referece to the inode (__iget()) and later to call iput(). > > This problem goes away with the sync scalability patchset that josef > has been trying to get merged: > > git://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git superblock-scaling > > That patchset removes the full sb inodes list walk in > wait_sb_inodes() and replaces it with a walk of inodes cleaned > during the sync, which will be an empty list in the case of sync > running on an empty filesystem. This commit does the work: s/empty/frozen -Dave. -- Dave Chinner david@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to top | Article view | linux.kernel
csiph-web