Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1180531

Re: [RFC PATCH] perf: Provide status of known PMUs

Show all headers | View raw

* Adrian Hunter <adrian.hunter@intel.com> wrote:

> Known PMUs may not be present for various reasons.
> Provide a way for the user to know what the reason
> is.
> 
> A bus attribute is created for each known PMU beneath
> a group "known_pmus".  The attribute name is the same
> as the PMU name.  The value is a string consisting of
> one or, optionally, two parts: a canonical part, and
> a driver specific part.  If there are two parts, they
> are separated by " - ".  The canonical part is one of:
> 
> 	Supported
> 	Driver error
> 	Driver not loaded
> 	Driver not in kernel config
> 	Not supported by kernel
> 	Not supported by hardware
> 	Wrong vendor
> 	Wrong architecture
> 	Unknown status

Very nice!

> Example:
> 
> 	$ cat /sys/bus/event_source/known_pmus/intel_pt
> 	Supported

So I only have naming nits. 'Supported' is a bit ambiguous, because it could mean 
that the PMU is supported but the driver is not active. How about 'Enabled'?

I'd also make the strings more unambiguously structured, something like:

	Enabled
	Disabled: Driver error
	Disabled: Driver not loaded
	Disabled: Driver not in kernel config
	Disabled: Not supported by the kernel
	Disabled: Not supported by the hardware
	Disabled: Not supported by the hardware vendor
	Disabled: Not supported by the the architecture
	Disabled: Unknown status

(Note the small changes I did to the text in some places.)

Also note that I'd suggest not enumerating all the error reasons rigidly - just 
have a single error code, but a free flowing error string that is provided by the 
low level driver (and maybe strdup()-ed by the core). That way you can provide 
very specific error descriptions, without having to change the core every time you 
need a new category. Agreed?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH] perf: Provide status of known PMUs Adrian Hunter <adrian.hunter@intel.com> - 2015-07-09 10:00 +0200
  Re: [RFC PATCH] perf: Provide status of known PMUs Ingo Molnar <mingo@kernel.org> - 2015-07-09 10:20 +0200
    Re: [RFC PATCH] perf: Provide status of known PMUs Adrian Hunter <adrian.hunter@intel.com> - 2015-07-09 10:50 +0200
  Re: [RFC PATCH] perf: Provide status of known PMUs Peter Zijlstra <peterz@infradead.org> - 2015-07-09 11:00 +0200
    Re: [RFC PATCH] perf: Provide status of known PMUs Peter Zijlstra <peterz@infradead.org> - 2015-07-09 13:50 +0200
    Re: [RFC PATCH] perf: Provide status of known PMUs Peter Zijlstra <peterz@infradead.org> - 2015-07-09 14:10 +0200
      Re: [RFC PATCH] perf: Provide status of known PMUs Ingo Molnar <mingo@kernel.org> - 2015-07-09 14:40 +0200
        Re: [RFC PATCH] perf: Provide status of known PMUs Peter Zijlstra <peterz@infradead.org> - 2015-07-09 14:50 +0200
          Re: [RFC PATCH] perf: Provide status of known PMUs Ingo Molnar <mingo@kernel.org> - 2015-07-10 10:40 +0200

csiph-web