Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

From	Scott Wood <scottwood@freescale.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver
Date	2015-07-10 19:40 +0200
Message-ID	<pKKrg-t8-33@gated-at.bofh.it> (permalink)
References	<pKqCe-4Ra-9@gated-at.bofh.it> <pKqLU-4Uq-21@gated-at.bofh.it> <pKEOR-5oB-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2015-07-10 at 13:36 +0200, Paul Bolle wrote:
> On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote:
> > +#ifdef CONFIG_FSL_DPA_CHECKING
> > +#define DPA_ASSERT(x) \
> > +   do { \
> > +           if (!(x)) { \
> > +                   pr_crit("ASSERT: (%s:%d) %s\n", __FILE__, __LINE__, \
> > +                           __stringify_1(x)); \
> > +                   dump_stack(); \
> > +                   panic("assertion failure"); \
> 
> Not my call, but why panic() here?

I'm pretty sure I've complained about this before (as well as all the 
BUG_ONs).

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management  driver Scott Wood <scottwood@freescale.com> - 2015-07-10 19:40 +0200

csiph-web