Re: [RFC][PATCH] x86: Allow early_printk to use console style param like 115200n8

Path	csiph.com!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH] x86: Allow early_printk to use console style param like 115200n8
Date	Sun, 05 Jul 2015 11:10:03 +0200
Message-ID	<pIO5Z-W8-33@gated-at.bofh.it> (permalink)
References	<pIhto-5M4-3@gated-at.bofh.it> <pINCX-wQ-35@gated-at.bofh.it> <pINCY-wQ-51@gated-at.bofh.it>
X-Original-To	Steven Rostedt <rostedt@goodmis.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=EM5sPDJQDtNyQqzClYIFBOUH39cJrfoh+sYEGWsbLVk=; b=xL8JK8la/DTVTx6requGrfBxX7sYPv3lY73C3SoUnaWVg0MYdfC5G3sWE/4dCAPZHS UmNFZwSD9fHNlpAQiZzFhbdtOo/f2nYfIjDnHOuDD5yygNsSYQBM2XWTs+CPQhul/akf aPnh9sDpXZY/X3q4otB5o/q6nIuTIhUaQag1YbcHoZh/msLfvVunQ9B+sHoo5WHx2Dl/ bGD8zIU6g0M5+pA/2+ouA3CwSdG4+o4K7EaOqsXSnJLQpD2aceYvBANS0eVWvDYWAmJx sCU4OCwohrVZyQ9mk9pd1pWmueYgQQ98l6gXpNRQu37DRE0EvfgE89wGe7se56v6SSVG 7IcQ==
X-Received	by 10.180.80.229 with SMTP id u5mr76481728wix.92.1436087117813; Sun, 05 Jul 2015 02:05:17 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>, Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, David Cohen <david.a.cohen@linux.intel.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Alan Cox <alan@linux.intel.com>, "Stuart R. Anderson" <stuart.r.anderson@intel.com>
X-Original-Date	Sun, 5 Jul 2015 11:05:13 +0200
X-Original-Message-ID	<20150705090513.GC30626@gmail.com>
X-Original-References	<20150703181643.4fd4053d@grimm.local.home> <20150704110359.GA18107@gmail.com> <20150704092000.322dc4e6@grimm.local.home>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1176919

Show key headers only | View raw

* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Sat, 4 Jul 2015 13:03:59 +0200
> Ingo Molnar <mingo@kernel.org> wrote:
> 
> 
> > > +		/*
> > > +		 * In case the input is like console with text after the baud
> > > +		 * rate. e.g. 115200n8. kstrtoul() will error on such input.
> > > +		 */
> > > +		for (p = s; *p && isdigit(*p); p++)
> > > +			;
> > > +		*p = 0;
> > > +
> > >  		if (kstrtoul(s, 0, &baud) < 0 || baud == 0)
> > >  			baud = DEFAULT_BAUD;
> > 
> >
> 
> This was actually one of those cases where I wanted to show that keeping the old 
> function around is better than the alternative ;-)
> 
> If people say we need to phase out simple_strtoull(), then I wanted to show what 
> kinds of hacks we will have if that happens.
> 
> I was hoping that someone would point out that simple_strtoull() is a better 
> solution. :)

LOL :)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC][PATCH] x86: Allow early_printk to use console style param  like 115200n8 Steven Rostedt <rostedt@goodmis.org> - 2015-07-05 10:40 +0200
  Re: [RFC][PATCH] x86: Allow early_printk to use console style param  like 115200n8 Ingo Molnar <mingo@kernel.org> - 2015-07-05 11:10 +0200

csiph-web