Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1176919

Re: [RFC][PATCH] x86: Allow early_printk to use console style param like 115200n8

Show all headers | View raw

* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Sat, 4 Jul 2015 13:03:59 +0200
> Ingo Molnar <mingo@kernel.org> wrote:
> 
> 
> > > +		/*
> > > +		 * In case the input is like console with text after the baud
> > > +		 * rate. e.g. 115200n8. kstrtoul() will error on such input.
> > > +		 */
> > > +		for (p = s; *p && isdigit(*p); p++)
> > > +			;
> > > +		*p = 0;
> > > +
> > >  		if (kstrtoul(s, 0, &baud) < 0 || baud == 0)
> > >  			baud = DEFAULT_BAUD;
> > 
> >
> 
> This was actually one of those cases where I wanted to show that keeping the old 
> function around is better than the alternative ;-)
> 
> If people say we need to phase out simple_strtoull(), then I wanted to show what 
> kinds of hacks we will have if that happens.
> 
> I was hoping that someone would point out that simple_strtoull() is a better 
> solution. :)

LOL :)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC][PATCH] x86: Allow early_printk to use console style param  like 115200n8 Steven Rostedt <rostedt@goodmis.org> - 2015-07-05 10:40 +0200
  Re: [RFC][PATCH] x86: Allow early_printk to use console style param  like 115200n8 Ingo Molnar <mingo@kernel.org> - 2015-07-05 11:10 +0200

csiph-web