Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1176918
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | David Herrmann <dh.herrmann@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH RFC 5/5] kdbus: improve tests on incrementing quota |
| Date | Sun, 05 Jul 2015 11:10:03 +0200 |
| Message-ID | <pIO5Z-W8-29@gated-at.bofh.it> (permalink) |
| References | <pGkOJ-5Cy-3@gated-at.bofh.it> <pGkOK-5Cy-5@gated-at.bofh.it> <pHIvE-qX-5@gated-at.bofh.it> <pHN2i-3lz-17@gated-at.bofh.it> <pHNvl-3Pj-35@gated-at.bofh.it> <pHQMx-5Ls-1@gated-at.bofh.it> |
| X-Original-To | Sergei Zviagintsev <sergei@s15v.net> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=atKAtoqBur/s+tNSaauRViC4Jr5n9rA7ipK2I7CbCdY=; b=c1tYXZJwqfNZJPddT9jdN/5LcncCYvhbq4ZumTekhifgBvLPrYe4Nx1rE0ILlipS1U HH021G7GtcVdlIpma9NsjV5QmRBs16PcM4TQrORkflpvG6xDc3cw+ReF9S+Y5S/Lh7y3 ujPxZZn6hTRTmYGxSLfhvfeQ+SpYxvEeJNyaEDs0F0d3ddZVjgGHQi6v3LOEWp1d7N81 l1ogmxvHVv3JoJSYujdcLqOey1IwleFhyoHeSuJw4GhTgi9y4bPLC3/iQSVkpYRcG3b9 clrenQdgYiQB7GK0ls0VlfUrUUm0fHUTiYCyexJLL8r3SlDeScG51dka+m5YvuzbOy74 IKBQ== |
| MIME-Version | 1.0 |
| X-Received | by 10.112.63.169 with SMTP id h9mr8459289lbs.104.1436010486557; Sat, 04 Jul 2015 04:48:06 -0700 (PDT) |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 33 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Djalal Harouni <tixxdz@opendz.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Daniel Mack <daniel@zonque.org>, David Herrmann <dh.herrmann@googlemail.com>, linux-kernel <linux-kernel@vger.kernel.org> |
| X-Original-Date | Sat, 4 Jul 2015 13:48:06 +0200 |
| X-Original-Message-ID | <CANq1E4ShamZHhCNdwAL2oYEcij-YZifEwcqN_AviV7R7TKLdtQ@mail.gmail.com> |
| X-Original-References | <1435497454-10464-1-git-send-email-sergei@s15v.net> <1435497454-10464-6-git-send-email-sergei@s15v.net> <CANq1E4Seddy4YQ-v0A0QCNRozVXEwojsKCb5ejNqXyjbt26etw@mail.gmail.com> <20150702134500.GS17917@localhost.localdomain> <20150702141341.GA5452@dztty> <20150702174725.GV17917@localhost.localdomain> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | aioe.org linux.kernel:1176918 |
Show key headers only | View raw
Hi On Thu, Jul 2, 2015 at 7:47 PM, Sergei Zviagintsev <sergei@s15v.net> wrote: > Hi Djalal, > > On Thu, Jul 02, 2015 at 03:13:41PM +0100, Djalal Harouni wrote: > [...] >> > My journey with this piece of code began from spotting and immediately >> > "fixing" the overflow issue :) Then I decided to dig into the >> > out-of-tree repo to find the origin of this line. What I found were >> > commits af8e2f750985 and ac5c385cc67a in which Djalal "fixed" it as >> > well, but then reverted back to the original code. >> > >> > Surely we can drop this explanation, but if one of kdbus maintainers >> > experienced difficulties in understanding this piece of code, wouldn't >> > one who sees this code in the first time have the same issues? >> Yes there was lot of work in this area to make sure that the quota >> accounting is correct! the previous commits the one that tried to clean >> things up and the revert were both correct :-) , > > I cannot agree that commit af8e2f750985 in out-of-tree repo was correct. Exactly, that's why the commit got reverted. The U32_MAX check is *not* about overflows of pool-memory, but rather about overflows in quota-accounting. Thanks David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH RFC 5/5] kdbus: improve tests on incrementing quota David Herrmann <dh.herrmann@gmail.com> - 2015-07-02 11:00 +0200
Re: [PATCH RFC 5/5] kdbus: improve tests on incrementing quota Sergei Zviagintsev <sergei@s15v.net> - 2015-07-02 15:50 +0200
Re: [PATCH RFC 5/5] kdbus: improve tests on incrementing quota Djalal Harouni <tixxdz@opendz.org> - 2015-07-02 16:20 +0200
Re: [PATCH RFC 5/5] kdbus: improve tests on incrementing quota David Herrmann <dh.herrmann@gmail.com> - 2015-07-05 11:10 +0200
Re: [PATCH RFC 5/5] kdbus: improve tests on incrementing quota Sergei Zviagintsev <sergei@s15v.net> - 2015-07-05 10:30 +0200
csiph-web