Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1176430

Re: Possible regression due to "tick: broadcast: Prevent livelock from event handler"

Show key headers only | View raw

On Fri, 3 Jul 2015, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, Jul 3, 2015 at 4:40 AM, Simon Horman <horms@verge.net.au> wrote:
> > I have observed what appears to be a regression while testing next-20150702
> > which seems to be caused by 2951d5c031a3 ("tick: broadcast: Prevent
> > livelock from event handler").
> >
> > The problem manifests on the emev2/kzm9d board as per the boot log below.
> >
> > The problem manifests when booting using the shmobile_defconfig,
> > which uses multiplatform and enables all devices using DT.
> >
> > The problem does not appear to always manifest but anecdotally it
> > seems to manifest more often of late (yes, I know that is vague).
> 
> > hctosys: unable to open rtc device (rtc0)
> >
> > The boot hangs here.
> > The next line should be:
> >
> > smsc911x 20000000.ethernet eth0: SMSC911x/921x identified at 0xc8880000, IRQ: 33
> 
> As you can reproduce it, can you please try enabling lockdep debugging?

Just looking at the em_sti driver. It calls clk_prepare/unprepare from
interrupt disabled regions ...

But that's not the problem at hand I think. The above commit is moving
the call to the event handler on the local cpu out of the broadcast
lock region to prevent a live lock. The only real change is the
timing.

Before:

	bc_handler()
	  lock(bc_lock);
	  call_local_handler();
	  send_ipis();
	  reprogramm_bc_device();
	  unlock(bc_lock);

After:

	bc_handler()
	  lock(bc_lock);
	  send_ipis();
	  reprogramm_bc_device();
	  unlock(bc_lock);
	  call_local_handler();

As this runs in hard interrupt context with interrupts disabled, I
really cannot figure out how that makes a difference.

Can you add some debugging to figure out whether the broadcast timer
interrupt still fires?

Thanks,

	tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Possible regression due to "tick: broadcast: Prevent livelock from  event handler" Simon Horman <horms@verge.net.au> - 2015-07-03 04:50 +0200
  Re: Possible regression due to "tick: broadcast: Prevent livelock  from event handler" Thomas Gleixner <tglx@linutronix.de> - 2015-07-03 11:30 +0200
  Re: Possible regression due to "tick: broadcast: Prevent livelock  from event handler" Wolfram Sang <wsa@the-dreams.de> - 2015-07-03 13:00 +0200
    Re: Possible regression due to "tick: broadcast: Prevent livelock  from event handler" Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-07-03 13:10 +0200
    Re: Possible regression due to "tick: broadcast: Prevent livelock  from event handler" Thomas Gleixner <tglx@linutronix.de> - 2015-07-03 15:30 +0200
      Re: Possible regression due to "tick: broadcast: Prevent livelock  from event handler" Wolfram Sang <wsa@the-dreams.de> - 2015-07-03 15:40 +0200
        Re: Possible regression due to "tick: broadcast: Prevent livelock  from event handler" Thomas Gleixner <tglx@linutronix.de> - 2015-07-03 16:20 +0200
          Re: Possible regression due to "tick: broadcast: Prevent livelock  from event handler" Wolfram Sang <wsa@the-dreams.de> - 2015-07-03 16:40 +0200
            Re: Possible regression due to "tick: broadcast: Prevent livelock  from event handler" Sudeep Holla <sudeep.holla@arm.com> - 2015-07-03 16:50 +0200
              Re: Possible regression due to "tick: broadcast: Prevent livelock  from event handler" Sudeep Holla <sudeep.holla@arm.com> - 2015-07-03 17:00 +0200
              Re: Possible regression due to "tick: broadcast: Prevent livelock  from event handler" Thomas Gleixner <tglx@linutronix.de> - 2015-07-03 17:00 +0200
            Re: Possible regression due to "tick: broadcast: Prevent livelock  from event handler" Thomas Gleixner <tglx@linutronix.de> - 2015-07-03 17:00 +0200
              Re: Possible regression due to "tick: broadcast: Prevent livelock  from event handler" Wolfram Sang <wsa@the-dreams.de> - 2015-07-03 17:20 +0200
                Re: Possible regression due to "tick: broadcast: Prevent livelock  from event handler" Thomas Gleixner <tglx@linutronix.de> - 2015-07-03 17:30 +0200
                Re: Possible regression due to "tick: broadcast: Prevent livelock  from event handler" Wolfram Sang <wsa@the-dreams.de> - 2015-07-03 17:50 +0200
                Re: Possible regression due to "tick: broadcast: Prevent livelock  from event handler" Thomas Gleixner <tglx@linutronix.de> - 2015-07-03 18:00 +0200
                Re: Possible regression due to "tick: broadcast: Prevent livelock  from event handler" Wolfram Sang <wsa@the-dreams.de> - 2015-07-03 18:10 +0200
            Re: Possible regression due to "tick: broadcast: Prevent livelock  from event handler" Geert Uytterhoeven <geert@linux-m68k.org> - 2015-07-03 19:10 +0200

csiph-web