Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1175067

Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue

Show all headers | View raw

On Wed, Jul 01, 2015 at 01:06:48PM +0530, Sohny Thomas wrote:
<snip>
> >No, now this will introduce a new checkpatch warning that "else is not
> >required after return". why did you introduce this "else"?
> I did this so that the code is more readable and understandable, I
> checked and checkpatch didn't call this out , so its clean.
> 
> Otherwise the above code looks like this
> 
> if(i)
>    return 1;
> return 0;
you should update your tree. virtpci folder has been deleted from
unisys driver.
As you are using an old tree, maybe that explains why checkpatch is not
giving the error.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: unisys: virtpci: fixed a brace coding style issue Sohny Thomas <sohnythomas@zoho.com> - 2015-06-30 23:40 +0200
  Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style  issue Sohny Thomas <sohnythomas@zoho.com> - 2015-07-01 09:40 +0200
    Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style  issue Julia Lawall <julia.lawall@lip6.fr> - 2015-07-01 10:10 +0200
    Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style  issue Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-07-01 10:10 +0200
      Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style  issue Sohny Thomas <sohnythomas@zoho.com> - 2015-07-01 10:40 +0200

csiph-web