Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue

From	Sohny Thomas <sohnythomas@zoho.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue
Date	2015-07-01 10:40 +0200
Message-ID	<pHlIK-2Mw-21@gated-at.bofh.it> (permalink)
References	<pHbq1-5IH-3@gated-at.bofh.it> <pHk9Y-1I7-11@gated-at.bofh.it> <pHkMF-2aU-13@gated-at.bofh.it> <pHlfI-2Ay-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Wednesday 01 July 2015 01:32 PM, Sudip Mukherjee wrote:
> On Wed, Jul 01, 2015 at 01:06:48PM +0530, Sohny Thomas wrote:
> <snip>
>>> No, now this will introduce a new checkpatch warning that "else is not
>>> required after return". why did you introduce this "else"?
>> I did this so that the code is more readable and understandable, I
>> checked and checkpatch didn't call this out , so its clean.
>>
>> Otherwise the above code looks like this
>>
>> if(i)
>>    return 1;
>> return 0;
> you should update your tree. virtpci folder has been deleted from
> unisys driver.
> As you are using an old tree, maybe that explains why checkpatch is not
> giving the error.

This is from linux-stable branch and I updated  it just yesterday, so looks like the folders still there
> 
> regards
> sudip
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: unisys: virtpci: fixed a brace coding style issue Sohny Thomas <sohnythomas@zoho.com> - 2015-06-30 23:40 +0200
  Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style  issue Sohny Thomas <sohnythomas@zoho.com> - 2015-07-01 09:40 +0200
    Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style  issue Julia Lawall <julia.lawall@lip6.fr> - 2015-07-01 10:10 +0200
    Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style  issue Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-07-01 10:10 +0200
      Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style  issue Sohny Thomas <sohnythomas@zoho.com> - 2015-07-01 10:40 +0200

csiph-web