Re: vfio: powerpc/spapr: One function call less in tce_iommu_attach_group() after kzalloc() failure

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Alexey Kardashevskiy <aik@ozlabs.ru>
Newsgroups	linux.kernel
Subject	Re: vfio: powerpc/spapr: One function call less in tce_iommu_attach_group() after kzalloc() failure
Date	Tue, 30 Jun 2015 12:40:01 +0200
Message-ID	<pH17j-7DB-7@gated-at.bofh.it> (permalink)
References	<mSsDN-4wa-35@gated-at.bofh.it> <mSsDN-4wa-39@gated-at.bofh.it> <mSsDN-4wa-41@gated-at.bofh.it> <mSsDN-4wa-43@gated-at.bofh.it> <mSsDN-4wa-45@gated-at.bofh.it> <mSsDN-4wa-47@gated-at.bofh.it> <mSsDN-4wa-49@gated-at.bofh.it> <mSsDN-4wa-51@gated-at.bofh.it> <mSsDN-4wa-53@gated-at.bofh.it> <mSsDN-4wa-55@gated-at.bofh.it> <mSsDN-4wa-57@gated-at.bofh.it> <mSsDN-4wa-59@gated-at.bofh.it> <mSsDN-4wa-61@gated-at.bofh.it> <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <pGntf-138-9@gated-at.bofh.it> <pGnCV-1er-3@gated-at.bofh.it> <pGuuK-2zg-3@gated-at.bofh.it> <pGAqt-2Xb-1@gated-at.bofh.it> <pGRKG-2v9-11@gated-at.bofh.it> <pGWU2-1Eg-5@gated-at.bofh.it>
X-Original-To	SF Markus Elfring <elfring@users.sourceforge.net>, Alex Williamson <alex.williamson@redhat.com>, kvm@vger.kernel.org
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=svxWKJSfzka3itIlYY7ZzNZplBy64DpiZlB8gtlukEk=; b=L3IotmySUN/ImSZOps+/dl/vPgl5KE+8GcbMRg6l968J+E6S99K5DL/20q5KLGTtkK BsihCa6dMM1zVtsnvo7WGmooYkJidWN8z/yDn+6iBhKah25lcuSNFTV6ZSLBQhgklk8h FXFu6pEfyvwzSI0Gu4eP+UmIFlHT3v9nSAk2xmyM1oQguNt6Gk/UcMQEYHCROmhgFu1H CxUQgACebgSv7dzIO95gvRXdLW0rUgaeXyJWE/6dMrOKHt/aVDtt0FqIU13TlD12KBTQ RNQglRSJw0/5Exb6rTA8RcL9uBDCW0hyJtOrD//Y5RqRAcpBRa7m8TbNM/kaPjeiq2rF Y+YA==
X-Gm-Message-State	ALoCoQmqPId7YzHPV7LNIQgF5ANxIpqHZd8S+W07UGqAGLDiEweweg6GNL4+/ZLxlL6JSHifxAPx
X-Received	by 10.68.218.103 with SMTP id pf7mr41870219pbc.32.1435660614470; Tue, 30 Jun 2015 03:36:54 -0700 (PDT)
User-Agent	Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1
MIME-Version	1.0
Content-Type	text/plain; charset=koi8-r; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	23
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>, Michael Ellerman <mpe@ellerman.id.au>
X-Original-Date	Tue, 30 Jun 2015 20:36:45 +1000
X-Original-Message-ID	<5592713D.10701@ozlabs.ru>
X-Original-References	<5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6> <530A72AA.3000601@users.sourceforge.net> <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6> <530B5FB6.6010207@users.sourceforge.net> <alpine.DEB.2.10.1402241710370.2074@hadrien> <530C5E18.1020800@users.sourceforge.net> <alpine.DEB.2.10.1402251014170.2080@hadrien> <530CD2C4.4050903@users.sourceforge.net> <alpine.DEB.2.10.1402251840450.7035@hadrien> <530CF8FF.8080600@users.sourceforge.net> <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6> <530DD06F.4090703@users.sourceforge.net> <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6> <5317A59D.4@users.sourceforge.net> <55901E68.80205@users.sourceforge.net> <55901FAC.1090109@users.sourceforge.net> <5590862A.3010603@ozlabs.ru> <5590DF8A.8030503@users.sourceforge.net> <5591E355.1080708@ozlabs.ru> <55923251.7070306@users.sourceforge.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1174429

Show key headers only | View raw

On 06/30/2015 04:08 PM, SF Markus Elfring wrote:
>>>> than the existing one should have been renamed to "free_exit" or "free_unlock_exit"
>>>> and new one would be "unlock_exit".
>>>
>>> I chose a smaller change at this place.
>>
>> I'd just drop this patch.
>
> How do you think about to improve the affected jump labels
> a bit more there?

This branch is very unlikely to work ever so I cannot think of any 
improvement here.



-- 
Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] vfio: powerpc/spapr: One function call less in  tce_iommu_attach_group() after kzalloc() failure Alexey Kardashevskiy <aik@ozlabs.ru> - 2015-06-29 01:50 +0200
  Re: vfio: powerpc/spapr: One function call less in  tce_iommu_attach_group() after kzalloc() failure Alexey Kardashevskiy <aik@ozlabs.ru> - 2015-06-30 02:40 +0200
    Re: vfio: powerpc/spapr: One function call less in  tce_iommu_attach_group() after kzalloc() failure Alexey Kardashevskiy <aik@ozlabs.ru> - 2015-06-30 12:40 +0200

csiph-web