Re: vfio: powerpc/spapr: One function call less in tce_iommu_attach_group() after kzalloc() failure

From	Alexey Kardashevskiy <aik@ozlabs.ru>
Newsgroups	linux.kernel
Subject	Re: vfio: powerpc/spapr: One function call less in tce_iommu_attach_group() after kzalloc() failure
Date	2015-06-30 02:40 +0200
Message-ID	<pGRKG-2v9-11@gated-at.bofh.it> (permalink)
References	(16 earlier) <mSsDN-4wa-33@gated-at.bofh.it> <pGntf-138-9@gated-at.bofh.it> <pGnCV-1er-3@gated-at.bofh.it> <pGuuK-2zg-3@gated-at.bofh.it> <pGAqt-2Xb-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/29/2015 04:02 PM, SF Markus Elfring wrote:
>> tcegrp will be NULL and kfree() can handle this just fine
>
> The affected function did not show this API knowledge, did it?


but you fixed this in 1/2 :)

>
>
>> (is not it the whole point of this patchset
>> - remove the check and just call kfree() even if the pointer is NULL?).
>
> Partly, yes.
>
>
>> And if you wanted another label,
>
> I suggest this to improve corresponding exception handling.
>
>
>> than the existing one should have been renamed to "free_exit" or "free_unlock_exit"
>> and new one would be "unlock_exit".
>
> I chose a smaller change at this place.


I'd just drop this patch.


> I am not familiar enough with other called functions there at the moment.
> Are the remaining goto statements also update candidates?




-- 
Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 2/2] vfio: powerpc/spapr: One function call less in  tce_iommu_attach_group() after kzalloc() failure Alexey Kardashevskiy <aik@ozlabs.ru> - 2015-06-29 01:50 +0200
  Re: vfio: powerpc/spapr: One function call less in  tce_iommu_attach_group() after kzalloc() failure Alexey Kardashevskiy <aik@ozlabs.ru> - 2015-06-30 02:40 +0200
    Re: vfio: powerpc/spapr: One function call less in  tce_iommu_attach_group() after kzalloc() failure Alexey Kardashevskiy <aik@ozlabs.ru> - 2015-06-30 12:40 +0200

csiph-web