Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1173572
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Linus Torvalds <torvalds@linux-foundation.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] hpfs: add fstrim support |
| Date | Sun, 28 Jun 2015 23:50:02 +0200 |
| Message-ID | <pGsCC-8mR-5@gated-at.bofh.it> (permalink) |
| References | <pGkOK-5Cy-11@gated-at.bofh.it> <pGqUa-5T9-5@gated-at.bofh.it> <pGrQe-7dv-3@gated-at.bofh.it> |
| X-Original-To | Al Viro <viro@zeniv.linux.org.uk> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=eFKYN6iqhSIsH820duiO32qWmhAcDsKefILfLfbI3G0=; b=bkzipybrXlMdBpsdbL2vz5mOOh6pQocCiOY6vt4hz91amf7t4cfSrVyHWeWv9cj7mD KAU39ty68gC2Cyvk+tqn1Bknk4i7fhPheNddZBWUNyGgrxqCKqhHFReMI0SlyzPwSiPM gyRPp6OLomTLOQvEXR0j614EcMdBXWdqTxcYNBqbN5wlzPjtZ5pnwZ7xOtd/oqiADp6T IXDB41ytY9vsWIUJ+YjhfAtNjL9ql7slsDOWMMb4dMDB+YVFd56EdPDyurHXdjqf7yZ2 x/bG59QlOF0xAHR9YFze/F3XdoKPjpGS69i0XPHVpoVl6tg6+gxdsWfZoWmjpCATxXmk TUsQ== |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=eFKYN6iqhSIsH820duiO32qWmhAcDsKefILfLfbI3G0=; b=TfO9641f6ntFVSRn9Affkn9kxnXuH78F2R9Lt0qPtA1tfT9qPUIErBXTiXPTpN2sP5 rpgvGiyAMZITGOLbuEjVUShcifruQ2cQ9jeP0EB1f9Gb+bb48wa32XEXAm+M0HLodhMJ SO2EJ1xEaADM3efO8744oigBhVF/wsse+K5/4= |
| MIME-Version | 1.0 |
| X-Received | by 10.107.151.75 with SMTP id z72mr15171175iod.46.1435527971101; Sun, 28 Jun 2015 14:46:11 -0700 (PDT) |
| X-Google-Sender-Auth | 6SBpigndPGI-6m_6WxXzvAtsm6Y |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 17 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Mikulas Patocka <mikulas@twibright.com>, "Ted Ts'o" <tytso@google.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-fsdevel <linux-fsdevel@vger.kernel.org> |
| X-Original-Date | Sun, 28 Jun 2015 14:46:11 -0700 |
| X-Original-Message-ID | <CA+55aFwz4tf6kgHHt4Nnx7+2qXhrGUG1Exxx+FtTt4UvFr72wg@mail.gmail.com> |
| X-Original-References | <alpine.DEB.2.00.1506281506450.29365@leontynka> <CA+55aFzY9Y8tgrv=HW6Sia_CmgLvn6_pC4MnLQYbmC8Urfbh+Q@mail.gmail.com> <20150628205925.GX17109@ZenIV.linux.org.uk> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | aioe.org linux.kernel:1173572 |
Show key headers only | View raw
On Sun, Jun 28, 2015 at 1:59 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> More to the point, why bother with ->ioctl() at all? Why not make
> ->fitrim() a super_block method and let do_vfs_ioctl() handle all
> marshalling? As in
> (int *)fitrim(struct super_block *, struct fstrim_range *);
> guaranteed to be called only on a filesystem kept active by caller...
I'd be ok with that, but that's a bigger issue and I think would be a
separate second step from removing the whole compat mess anyway.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH] hpfs: add fstrim support Linus Torvalds <torvalds@linux-foundation.org> - 2015-06-28 23:50 +0200
csiph-web