Re: [PATCH] hpfs: add fstrim support

From	Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] hpfs: add fstrim support
Date	2015-06-28 23:50 +0200
Message-ID	<pGsCC-8mR-5@gated-at.bofh.it> (permalink)
References	<pGkOK-5Cy-11@gated-at.bofh.it> <pGqUa-5T9-5@gated-at.bofh.it> <pGrQe-7dv-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jun 28, 2015 at 1:59 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> More to the point, why bother with ->ioctl() at all?  Why not make
> ->fitrim() a super_block method and let do_vfs_ioctl() handle all
> marshalling?  As in
>         (int *)fitrim(struct super_block *, struct fstrim_range *);
> guaranteed to be called only on a filesystem kept active by caller...

I'd be ok with that, but that's a bigger issue and I think would be a
separate second step from removing the whole compat mess anyway.

                   Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] hpfs: add fstrim support Linus Torvalds <torvalds@linux-foundation.org> - 2015-06-28 23:50 +0200

csiph-web