Re: [PATCH v2 4/4] cpufreq: exynos: remove Exynos5250 specific cpufreq driver support

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/4] cpufreq: exynos: remove Exynos5250 specific cpufreq driver support
Date	Tue, 30 Jun 2015 02:30:01 +0200
Message-ID	<pGRAZ-2l0-1@gated-at.bofh.it> (permalink)
References	<pGL2x-1bz-1@gated-at.bofh.it> <pGL2y-1bz-27@gated-at.bofh.it>
X-Original-To	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Thomas Abraham <thomas.ab@samsung.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Michael Turquette <mturquette@baylibre.com>, Kukjin Kim <kgene.kim@samsung.com>, Kukjin Kim <kgene@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>
X-Auditid	cbfec7f5-f794b6d000001495-7c-5591e13269b6
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
X-Brightmail-Tracker	H4sIAAAAAAAAA+NgFlrBIsWRmVeSWpSXmKPExsVy+t/xa7pGDyeGGtx+yWaxccZ6VovrX56z Wvx/9JrV4trvGWwWr18YWvQuuMpm0f/4NbPF18MrGC3ePNzMaLHp8TVWi48991gtLu+aw2bx ufcIo8WM8/uYLC6ecrU4/Kad1aJjGaPFql1/GC02fvVwEPZ4f6OV3ePv7FZmj52z7rJ7bFrV yeZx59oeNo/NS+o9+rasYvTYfm0es8fnTXIBnFFcNimpOZllqUX6dglcGZ1/O9kKfnFWzF1+ lbmBsYOji5GTQ0LAROLLxvnsELaYxIV769m6GLk4hASWMko0/J4I5TxllOg98IwVpIpXQEui q/caM4jNIqAqsf74cxYQm03AWGLz8iVsILaoQITE28snmSDqBSV+TL7HAjJIRGA9k0TvxVtg U5kFpjBLzGzYAFYlLJAgsevtH3aIde2MEovPNYCN5RTwlHj4AsTmAOrQk7h/UQskzCwgL7F5 zVvmCYwCs5AsmYVQNQtJ1QJG5lWMoqmlyQXFSem5RnrFibnFpXnpesn5uZsYIfH3dQfj0mNW hxgFOBiVeHgbsyeGCrEmlhVX5h5ilOBgVhLhZYoFCvGmJFZWpRblxxeV5qQWH2KU5mBREued uet9iJBAemJJanZqakFqEUyWiYNTqoGx68q0Z/6XJqza/Dj7Qc6pDamPnj95PO+X0UzWMv/1 2lry647KW2QbLleqVApY8l34Qqw4z1nFxCAPRz2nNFH2uMNOT/yLjBRz1tUHLv0rNEdx8tSY FlMHxoNaigmXnUVOv5vGI7c8ZOWsNNZ5mnFro6en/D/fH33i4EZVTxWFiE+auyuNz6sqsRRn JBpqMRcVJwIAVThpObsCAAA=
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	Tomasz Figa <tomasz.figa@gmail.com>, Lukasz Majewski <l.majewski@samsung.com>, Heiko Stuebner <heiko@sntech.de>, Chanwoo Choi <cw00.choi@samsung.com>, Kevin Hilman <khilman@linaro.org>, Javier Martinez Canillas <javier@dowhile0.org>, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 30 Jun 2015 09:22:06 +0900
X-Original-Message-ID	<5591E12E.7060007@samsung.com>
X-Original-References	<1435598772-21708-1-git-send-email-b.zolnierkie@samsung.com> <1435598772-21708-5-git-send-email-b.zolnierkie@samsung.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1174153

Show key headers only | View raw

On 30.06.2015 02:26, Bartlomiej Zolnierkiewicz wrote:
> Exynos5250 based platforms have switched over to use generic
> cpufreq driver for cpufreq functionality. So the Exynos
> specific cpufreq support for these platforms can be removed.
> 
> Based on the earlier work by Thomas Abraham.
> 
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Cc: Thomas Abraham <thomas.ab@samsung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
>  drivers/cpufreq/Kconfig.arm          |  11 --
>  drivers/cpufreq/Makefile             |   1 -
>  drivers/cpufreq/exynos-cpufreq.c     |   3 -
>  drivers/cpufreq/exynos-cpufreq.h     |  17 ---
>  drivers/cpufreq/exynos5250-cpufreq.c | 210 -----------------------------------
>  5 files changed, 242 deletions(-)
>  delete mode 100644 drivers/cpufreq/exynos5250-cpufreq.c

Nice diff stat, I like it!

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Few thoughts:
1. Javier's email has changed, CC-ed the correct one. Can you update it
in all patches (CC-tags)?

2. It looks like the patchset should go through one tree so the
Exynos5250 cpufreq support won't disappear, right?


Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 4/4] cpufreq: exynos: remove Exynos5250 specific cpufreq  driver support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-06-30 02:30 +0200

csiph-web