Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1174154

Re: [PATCH-V5 3/4] mfd: 88pm800: Set default interrupt clear method

Show all headers | View raw

2015-06-30 0:31 GMT+09:00 Vaibhav Hiremath <vaibhav.hiremath@linaro.org>:
> As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe
> (page 0) controls the method of clearing interrupt
> status of 88pm800 family of devices;
>
>   0: clear on read
>   1: clear on write
>
> If pdata is not coming from board file, then set the
> default irq clear method to "irq clear on write"
>
> Also, as suggested by "Lee Jones" renaming variable field
> to appropriate name.
>
> Signed-off-by: Zhao Ye <zhaoy@marvell.com>
> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
> ---
>  drivers/mfd/88pm800.c       | 15 ++++++++++-----
>  include/linux/mfd/88pm80x.h | 10 ++++++++--
>  2 files changed, 18 insertions(+), 7 deletions(-)
>

Looks fine to me.

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH-V5 3/4] mfd: 88pm800: Set default interrupt clear method Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-06-29 17:40 +0200
  Re: [PATCH-V5 3/4] mfd: 88pm800: Set default interrupt clear method Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-06-30 02:30 +0200
  Re: [PATCH-V5 3/4] mfd: 88pm800: Set default interrupt clear method Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-07 12:00 +0200
    Re: [PATCH-V5 3/4] mfd: 88pm800: Set default interrupt clear method Lee Jones <lee.jones@linaro.org> - 2015-07-07 12:50 +0200
      Re: [PATCH-V5 3/4] mfd: 88pm800: Set default interrupt clear method Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-07 13:00 +0200
        Re: [PATCH-V5 3/4] mfd: 88pm800: Set default interrupt clear method Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-07 13:20 +0200
          Re: [PATCH-V5 3/4] mfd: 88pm800: Set default interrupt clear method Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-08 14:30 +0200
        Re: [PATCH-V5 3/4] mfd: 88pm800: Set default interrupt clear method Lee Jones <lee.jones@linaro.org> - 2015-07-07 13:20 +0200

csiph-web