Re: [PATCH] XFS: Delete unnecessary checks before the function call "xfs_qm_dqrele"

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Dave Chinner <david@fromorbit.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] XFS: Delete unnecessary checks before the function call "xfs_qm_dqrele"
Date	Mon, 29 Jun 2015 23:50:05 +0200
Message-ID	<pGP6d-79Z-103@gated-at.bofh.it> (permalink)
References	<mSsDN-4wa-55@gated-at.bofh.it> <mSsDN-4wa-57@gated-at.bofh.it> <mSsDN-4wa-59@gated-at.bofh.it> <mSsDN-4wa-61@gated-at.bofh.it> <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <orTnz-8mG-3@gated-at.bofh.it> <oslMR-1gx-11@gated-at.bofh.it> <pFxXI-2Uf-23@gated-at.bofh.it>
X-Original-To	SF Markus Elfring <elfring@users.sourceforge.net>
X-Ironport-Anti-Spam-Filtered	true
X-Ironport-Anti-Spam-Result	A2B3CADKupFVPN6zLHlbgxGBM4JQg3ykPQEBBo15jAMCAgEBAoE/TQEBAQEBAQcBAQEBQAE/hCIBAQEDATocIwULCAMUAQMJJQ8FJQMHGhOIJwfJcQEBAQEGAQEBAR4YhgSFLoUGB4MXgRQBBJEngl2LVI12ikaBCYFagU8sMYJIAQEB
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	31
Organization	linux.* mail to news gateway
X-Original-Cc	xfs@oss.sgi.com, LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>
X-Original-Date	Tue, 30 Jun 2015 07:43:55 +1000
X-Original-Message-ID	<20150629214355.GE7943@dastard>
X-Original-References	<530CD2C4.4050903@users.sourceforge.net> <alpine.DEB.2.10.1402251840450.7035@hadrien> <530CF8FF.8080600@users.sourceforge.net> <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6> <530DD06F.4090703@users.sourceforge.net> <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6> <5317A59D.4@users.sourceforge.net> <5479F823.60900@users.sourceforge.net> <20141130230904.GF16151@dastard> <558D1833.3080009@users.sourceforge.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1174129

Show key headers only | View raw

On Fri, Jun 26, 2015 at 11:15:31AM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 26 Jun 2015 11:05:41 +0200
> 
> The xfs_qm_dqrele() function tests whether its argument is NULL and
> then returns immediately.

True.

> Thus the test around the call is not needed.

But wrong.

xfs_dqrele_inode() gets called on every inode in the inode cache,
and this change results in a cacheline in every inode being dirtied
even if they don't have dquots attached. Given the inode cache can
hold tens to hundreds of millions of inodes on large machines, we
don't want to dirty any cachelines we don't need to while walking
the inode cache and releasing dquots...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] XFS: Delete unnecessary checks before the function call  "xfs_qm_dqrele" Dave Chinner <david@fromorbit.com> - 2015-06-29 23:50 +0200
  Re: XFS: Fine-tuning for checks before the function call "xfs_qm_dqrele"? SF Markus Elfring <elfring@users.sourceforge.net> - 2015-07-01 10:00 +0200
    Re: XFS: Fine-tuning for checks before the function call  "xfs_qm_dqrele"? Dave Chinner <david@fromorbit.com> - 2015-07-02 02:30 +0200

csiph-web