Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1175060
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: XFS: Fine-tuning for checks before the function call "xfs_qm_dqrele"? |
| Date | 2015-07-01 10:00 +0200 |
| Message-ID | <pHl63-2i0-37@gated-at.bofh.it> (permalink) |
| References | (6 earlier) <mSsDN-4wa-33@gated-at.bofh.it> <orTnz-8mG-3@gated-at.bofh.it> <oslMR-1gx-11@gated-at.bofh.it> <pFxXI-2Uf-23@gated-at.bofh.it> <pGP6d-79Z-103@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> xfs_dqrele_inode() gets called on every inode in the inode cache, > and this change results in a cacheline in every inode being dirtied > even if they don't have dquots attached. Given the inode cache can > hold tens to hundreds of millions of inodes on large machines, we > don't want to dirty any cachelines we don't need to while walking > the inode cache and releasing dquots... Would it make sense to annotate checks before such function calls as "LIKELY"? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] XFS: Delete unnecessary checks before the function call "xfs_qm_dqrele" Dave Chinner <david@fromorbit.com> - 2015-06-29 23:50 +0200
Re: XFS: Fine-tuning for checks before the function call "xfs_qm_dqrele"? SF Markus Elfring <elfring@users.sourceforge.net> - 2015-07-01 10:00 +0200
Re: XFS: Fine-tuning for checks before the function call "xfs_qm_dqrele"? Dave Chinner <david@fromorbit.com> - 2015-07-02 02:30 +0200
csiph-web