Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

From	Arjan van de Ven <arjan@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep
Date	2015-06-29 16:40 +0200
Message-ID	<pGIo2-5Kx-13@gated-at.bofh.it> (permalink)
References	(6 earlier) <pFslj-3jg-3@gated-at.bofh.it> <pGGPg-3qZ-3@gated-at.bofh.it> <pGGYV-3RN-1@gated-at.bofh.it> <pGHV0-5cS-19@gated-at.bofh.it> <pGIem-5zg-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 6/29/2015 7:22 AM, Mark Brown wrote:
> On Mon, Jun 29, 2015 at 10:03:09PM +0800, Nicolas Boichat wrote:
>
>> regmap instances are kalloc'ed, so they cannot contain the
>> lock_class_key, which needs to be statically allocated (in .data).
>> Another option would be to preallocate a bunch of lock_class_key in
>> regmap.c, and pick from that, but that's terribly hacky...
>
> Honestly this is all starting to sound like we're having to jump through
> too many hoops for lockep (and other APIs are too from the sounds of it)
> so we should be looking at lockdep here.

lockdep assumes that there is a known lock hierarchy, at least known
to the developer.

seems like for regmap there isn't

(I would be interested to know how you avoid ABBA deadlocks btw,
can you have 2 devices, one with a hierarchy one way, and another
with the hierarchy the other way?)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[RFC PATCH 1/2] regmap: add configurable lock class key for lockdep Nicolas Boichat <drinkcat@chromium.org> - 2015-06-25 11:40 +0200
  [RFC PATCH 2/2] ASoC: rt5677: Add lockdep class to silence lockdep warnings Nicolas Boichat <drinkcat@chromium.org> - 2015-06-25 11:40 +0200
  Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep Nicolas Boichat <drinkcat@chromium.org> - 2015-06-26 04:40 +0200
  Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep Nicolas Boichat <drinkcat@chromium.org> - 2015-06-26 05:20 +0200
    Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep Lars-Peter Clausen <lars@metafoo.de> - 2015-06-29 16:20 +0200
      Re: [RFC PATCH 1/2] regmap: add configurable lock class key for  lockdep Mark Brown <broonie@kernel.org> - 2015-06-29 17:40 +0200
        Re: [alsa-devel] [RFC PATCH 1/2] regmap: add configurable lock class  key for lockdep Lars-Peter Clausen <lars@metafoo.de> - 2015-06-30 13:10 +0200
    Re: [RFC PATCH 1/2] regmap: add configurable lock class key for  lockdep Mark Brown <broonie@kernel.org> - 2015-06-29 16:30 +0200
      Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep Arjan van de Ven <arjan@linux.intel.com> - 2015-06-29 16:40 +0200
        Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep Arjan van de Ven <arjan@linux.intel.com> - 2015-06-29 17:40 +0200
        Re: [RFC PATCH 1/2] regmap: add configurable lock class key for  lockdep Mark Brown <broonie@kernel.org> - 2015-06-29 17:40 +0200
    Re: [RFC PATCH 1/2] regmap: add configurable lock class key for  lockdep Mark Brown <broonie@kernel.org> - 2015-06-29 16:30 +0200

csiph-web