Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep
Date	2015-06-29 16:30 +0200
Message-ID	<pGIem-5zg-23@gated-at.bofh.it> (permalink)
References	(4 earlier) <pFhzA-4C6-7@gated-at.bofh.it> <pFhSW-5dU-21@gated-at.bofh.it> <pFslj-3jg-3@gated-at.bofh.it> <pGGPg-3qZ-3@gated-at.bofh.it> <pGGYV-3RN-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Jun 29, 2015 at 02:59:57PM +0200, Lars-Peter Clausen wrote:

> Maybe we are just over-thinking this and should just add one key to each
> regmap instance. That solves the issue without requiring the any user
> interaction. The only downside is that it might impact the performance of
> lockdep and uses quite a few lock classes. Its probably manageable right now
> but could grow into a problem as regmap adoption further progresses. But
> maybe we can leave the hard work of figuring a better solution to our future
> selves.

I thought the issue with that was that all lockdep classes need to be
allocated statically?  If we can just do something that scales with
regmap instances I'm not sure there's a big problem, even if adoption
increases we're talking about something that scales with the number of
devices in the system rather than the number of drivers using the API
which should be a lot more manageable.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH 1/2] regmap: add configurable lock class key for lockdep Nicolas Boichat <drinkcat@chromium.org> - 2015-06-25 11:40 +0200
  [RFC PATCH 2/2] ASoC: rt5677: Add lockdep class to silence lockdep warnings Nicolas Boichat <drinkcat@chromium.org> - 2015-06-25 11:40 +0200
  Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep Nicolas Boichat <drinkcat@chromium.org> - 2015-06-26 04:40 +0200
  Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep Nicolas Boichat <drinkcat@chromium.org> - 2015-06-26 05:20 +0200
    Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep Lars-Peter Clausen <lars@metafoo.de> - 2015-06-29 16:20 +0200
      Re: [RFC PATCH 1/2] regmap: add configurable lock class key for  lockdep Mark Brown <broonie@kernel.org> - 2015-06-29 17:40 +0200
        Re: [alsa-devel] [RFC PATCH 1/2] regmap: add configurable lock class  key for lockdep Lars-Peter Clausen <lars@metafoo.de> - 2015-06-30 13:10 +0200
    Re: [RFC PATCH 1/2] regmap: add configurable lock class key for  lockdep Mark Brown <broonie@kernel.org> - 2015-06-29 16:30 +0200
      Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep Arjan van de Ven <arjan@linux.intel.com> - 2015-06-29 16:40 +0200
        Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep Arjan van de Ven <arjan@linux.intel.com> - 2015-06-29 17:40 +0200
        Re: [RFC PATCH 1/2] regmap: add configurable lock class key for  lockdep Mark Brown <broonie@kernel.org> - 2015-06-29 17:40 +0200
    Re: [RFC PATCH 1/2] regmap: add configurable lock class key for  lockdep Mark Brown <broonie@kernel.org> - 2015-06-29 16:30 +0200

csiph-web