Re: vdso && f_op->mremap (Was: special_mapping_fault() is broken)

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Andy Lutomirski <luto@amacapital.net>
Newsgroups	linux.kernel
Subject	Re: vdso && f_op->mremap (Was: special_mapping_fault() is broken)
Date	Tue, 23 Jun 2015 03:30:02 +0200
Message-ID	<pElce-4sd-5@gated-at.bofh.it> (permalink)
References	<pDUF3-8px-5@gated-at.bofh.it> <pDUYp-kA-9@gated-at.bofh.it> <pEkzw-3sg-7@gated-at.bofh.it>
X-Original-To	Oleg Nesterov <oleg@redhat.com>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=0huGWkVwTIV4sX4Xm7PPeh6vYBnCkFg5L9Uk2fGlemM=; b=iGkg49fnnM8EQ422DRl/KA45I22PyhHluI2lGkZlTvVbb4FW4veQOKV7ackDQv/iA/ u0MnxKeJuYe8WWqE2X1k2HfEuYuO1+Oe3fhYBH0Ch3ywjJrUq06j17vjZPou/eswk50M pnwvW8dPM5mP9IOtavCiLDlFbkN6SZB2I/aEbOJosciHsiMulSodvPCUDWT040Nj6yqK qs/yC81is3sp7od4rtZFNyo2lEith0yyskIK7qRmI8Vt49oUlazwTtKtZUSVcwnaevei //w7+Tzsz1lYiE1b/Yekk5dW3epinUReWz08DGGTGhQ3XnAkZsAw4FOuKThoYxZyCiKL v1WQ==
X-Gm-Message-State	ALoCoQmswDJjrv0u/AMEU91E0ZX7g6NzY9BObIoQ1vKhJINtYbhQ44JmSX+wEFJOHd/RW82dOHod
X-Received	by 10.152.121.42 with SMTP id lh10mr16837414lab.0.1435022826440; Mon, 22 Jun 2015 18:27:06 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	26
Organization	linux.* mail to news gateway
X-Original-Cc	Andrew Morton <akpm@linux-foundation.org>, Al Viro <viro@zeniv.linux.org.uk>, Benjamin LaHaise <bcrl@kvack.org>, Hugh Dickins <hughd@google.com>, Jeff Moyer <jmoyer@redhat.com>, Kirill Shutemov <kirill.shutemov@linux.intel.com>, Linus Torvalds <torvalds@linux-foundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Andy Lutomirski <luto@kernel.org>, Pavel Emelyanov <xemul@parallels.com>
X-Original-Date	Mon, 22 Jun 2015 18:26:46 -0700
X-Original-Message-ID	<CALCETrWgq3jUWwfa9z9Hq-pnWCp+SCV-iQC4BuV=VXDU10rk+g@mail.gmail.com>
X-Original-References	<20150621210725.GA18220@redhat.com> <20150621211951.GA18593@redhat.com> <20150623004744.GA11212@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1170330

Show key headers only | View raw

On Mon, Jun 22, 2015 at 5:47 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> On 06/21, Oleg Nesterov wrote:
>>
>> Forgot to add Andy...
>
> Add Pavel ;)
>
> I never understood why ->mremap() lives in file_operations, not in
> vm_operations_struct. To me vma->vm_file->f_op in move_vma() just
> looks strange, vma->vm_ops->mremap(new_vma) looks "obviously better".
>
> And afaics more useful. CRIU remaps vdso, but this does not update
> mm->context.vdso. OK, probably this does not matter currently, CRIU
> can't c/r the compat tasks, and 64-bit apps do not use context.vdso.
> Afaics. Still, I think we might want to have special_mapping_remap()
> and we can't do this because ->vm_file == NULL.

I would like this.  Then I could clean up and resubmit my patch to
keep context.vdso up to date.

Oleg, can you let me know what patch, if any, I should be reviewing?

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

vdso && f_op->mremap (Was: special_mapping_fault() is broken) Oleg Nesterov <oleg@redhat.com> - 2015-06-23 02:50 +0200
  Re: vdso && f_op->mremap (Was: special_mapping_fault() is broken) Linus Torvalds <torvalds@linux-foundation.org> - 2015-06-23 03:20 +0200
  Re: vdso && f_op->mremap (Was: special_mapping_fault() is broken) Andy Lutomirski <luto@amacapital.net> - 2015-06-23 03:30 +0200

csiph-web