vdso && f_op->mremap (Was: special_mapping_fault() is broken)

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	vdso && f_op->mremap (Was: special_mapping_fault() is broken)
Date	2015-06-23 02:50 +0200
Message-ID	<pEkzw-3sg-7@gated-at.bofh.it> (permalink)
References	<pDUF3-8px-5@gated-at.bofh.it> <pDUYp-kA-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/21, Oleg Nesterov wrote:
>
> Forgot to add Andy...

Add Pavel ;)

I never understood why ->mremap() lives in file_operations, not in
vm_operations_struct. To me vma->vm_file->f_op in move_vma() just
looks strange, vma->vm_ops->mremap(new_vma) looks "obviously better".

And afaics more useful. CRIU remaps vdso, but this does not update
mm->context.vdso. OK, probably this does not matter currently, CRIU
can't c/r the compat tasks, and 64-bit apps do not use context.vdso.
Afaics. Still, I think we might want to have special_mapping_remap()
and we can't do this because ->vm_file == NULL.

And perhaps other architectures can depend on the "correct" value
in >context.vdso more then x86, I dunno...

In short. Shouldn't we move ->mremap() to vm_operations_struct before
it has another user? We need to fix aio.c, but this is trivial.

No?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

vdso && f_op->mremap (Was: special_mapping_fault() is broken) Oleg Nesterov <oleg@redhat.com> - 2015-06-23 02:50 +0200
  Re: vdso && f_op->mremap (Was: special_mapping_fault() is broken) Linus Torvalds <torvalds@linux-foundation.org> - 2015-06-23 03:20 +0200
  Re: vdso && f_op->mremap (Was: special_mapping_fault() is broken) Andy Lutomirski <luto@amacapital.net> - 2015-06-23 03:30 +0200

csiph-web