Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1170324

Re: [PATCH v2] power: max17042_battery: add HEALTH and TEMP_* properties support

From Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] power: max17042_battery: add HEALTH and TEMP_* properties support
Date 2015-06-23 03:00 +0200
Message-ID <pEkJc-3Dy-21@gated-at.bofh.it> (permalink)
References <ptnr4-7do-13@gated-at.bofh.it> <pyU2Z-8s1-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


2015-06-08 10:22 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
> 2015-05-24 12:41 GMT+09:00 Ramakrishna Pallala <ramakrishna.pallala@intel.com>:
>> This patch adds the support for following battery properties
>> to max17042 fuel gauge driver.
>>
>> POWER_SUPPLY_PROP_TEMP_ALERT_MIN
>> POWER_SUPPLY_PROP_TEMP_ALERT_MAX
>> POWER_SUPPLY_PROP_TEMP_MIN
>> POWER_SUPPLY_PROP_TEMP_MAX
>> POWER_SUPPLY_PROP_HEALTH
>
> I wonder, have you tested the patch? After booting on Trats2 device
> (max77693 which identifies itself as 17047-like) the values are:
> POWER_SUPPLY_TEMP_ALERT_MIN=1280
> POWER_SUPPLY_TEMP_ALERT_MAX=1270
> POWER_SUPPLY_TEMP=257
> This is okay, datasheet says that register after booting will have
> value of 0x7f80.
>
> However setting them to some value which should trigger interrupts
> (like 300 for MIN or 200 for MAX) does not trigger the interrupt. I
> added a printk in max17042_thread_handler().
>
> Is the temperature alert feature working?

Dear Ramakrishna Pallala,

Can you reply to my question above?
If this feature is not working, then it should be removed.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2] power: max17042_battery: add HEALTH and TEMP_*  properties support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-06-08 03:30 +0200
  Re: [PATCH v2] power: max17042_battery: add HEALTH and TEMP_*  properties support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-06-23 03:00 +0200

csiph-web