Re: [PATCH 5/5] staging: lustre: osc: drop trivially useless initialization

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Julia Lawall <julia.lawall@lip6.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] staging: lustre: osc: drop trivially useless initialization
Date	Sun, 21 Jun 2015 02:50:01 +0200
Message-ID	<pDBCp-6cA-5@gated-at.bofh.it> (permalink)
References	<pDwt3-7lc-3@gated-at.bofh.it> <pDwt4-7lc-9@gated-at.bofh.it> <pDyOe-2a3-5@gated-at.bofh.it>
X-Original-To	Joachim Eastwood <manabian@gmail.com>
X-Ironport-Av	E=Sophos;i="5.13,651,1427752800"; d="scan'208";a="166456510"
X-X-Sender	jll@localhost6.localdomain6
User-Agent	Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version	1.0
Content-Type	TEXT/PLAIN; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	53
Organization	linux.* mail to news gateway
X-Original-Cc	Julia Lawall <Julia.Lawall@lip6.fr>, Oleg Drokin <oleg.drokin@intel.com>, kernel-janitors@vger.kernel.org, Andreas Dilger <andreas.dilger@intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Sun, 21 Jun 2015 02:49:34 +0200 (CEST)
X-Original-Message-ID	<alpine.DEB.2.02.1506210249180.2231@localhost6.localdomain6>
X-Original-References	<1434827273-13929-1-git-send-email-Julia.Lawall@lip6.fr> <1434827273-13929-6-git-send-email-Julia.Lawall@lip6.fr> <CAGhQ9VwuaSdEFj_X2=_re=A2kHh8NqhmMVOLTc9X8LOifLAUWw@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1169499

Show key headers only | View raw

On Sat, 20 Jun 2015, Joachim Eastwood wrote:

> On 20 June 2015 at 21:07, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> > Remove initialization of a variable that is immediately reassigned.
> >
> > The semantic patch that makes this change is as follows:
> > (http://coccinelle.lip6.fr/)
> >
> > // <smpl>
> > @@
> > type T;
> > identifier x;
> > constant C;
> > expression e;
> > @@
> >
> > T x
> > - = C
> >  ;
> > x = e;
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > ---
> >  drivers/staging/lustre/lustre/osc/osc_page.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff -u -p a/drivers/staging/lustre/lustre/osc/osc_page.c b/drivers/staging/lustre/lustre/osc/osc_page.c
> > --- a/drivers/staging/lustre/lustre/osc/osc_page.c
> > +++ b/drivers/staging/lustre/lustre/osc/osc_page.c
> > @@ -471,7 +471,7 @@ static int osc_page_flush(const struct l
> >                           struct cl_io *io)
> >  {
> >         struct osc_page *opg = cl2osc_page(slice);
> > -       int rc = 0;
> > +       int rc;
> >
> >         rc = osc_flush_async_page(env, io, opg);
> >         return rc;
> >
> 
> The whole rc variable is kinda useless.
> 
> Why not make it just:
> return osc_flush_async_page(env, io, opg);

Sure.  I'll fix that.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 5/5] staging: lustre: osc: drop trivially useless initialization Julia Lawall <Julia.Lawall@lip6.fr> - 2015-06-20 21:20 +0200
  Re: [PATCH 5/5] staging: lustre: osc: drop trivially useless  initialization Julia Lawall <julia.lawall@lip6.fr> - 2015-06-21 02:50 +0200

csiph-web