Re: [PATCH 5/5] staging: lustre: osc: drop trivially useless initialization

From	Julia Lawall <julia.lawall@lip6.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] staging: lustre: osc: drop trivially useless initialization
Date	2015-06-21 02:50 +0200
Message-ID	<pDBCp-6cA-5@gated-at.bofh.it> (permalink)
References	<pDwt3-7lc-3@gated-at.bofh.it> <pDwt4-7lc-9@gated-at.bofh.it> <pDyOe-2a3-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 20 Jun 2015, Joachim Eastwood wrote:

> On 20 June 2015 at 21:07, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> > Remove initialization of a variable that is immediately reassigned.
> >
> > The semantic patch that makes this change is as follows:
> > (http://coccinelle.lip6.fr/)
> >
> > // <smpl>
> > @@
> > type T;
> > identifier x;
> > constant C;
> > expression e;
> > @@
> >
> > T x
> > - = C
> >  ;
> > x = e;
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > ---
> >  drivers/staging/lustre/lustre/osc/osc_page.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff -u -p a/drivers/staging/lustre/lustre/osc/osc_page.c b/drivers/staging/lustre/lustre/osc/osc_page.c
> > --- a/drivers/staging/lustre/lustre/osc/osc_page.c
> > +++ b/drivers/staging/lustre/lustre/osc/osc_page.c
> > @@ -471,7 +471,7 @@ static int osc_page_flush(const struct l
> >                           struct cl_io *io)
> >  {
> >         struct osc_page *opg = cl2osc_page(slice);
> > -       int rc = 0;
> > +       int rc;
> >
> >         rc = osc_flush_async_page(env, io, opg);
> >         return rc;
> >
> 
> The whole rc variable is kinda useless.
> 
> Why not make it just:
> return osc_flush_async_page(env, io, opg);

Sure.  I'll fix that.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 5/5] staging: lustre: osc: drop trivially useless initialization Julia Lawall <Julia.Lawall@lip6.fr> - 2015-06-20 21:20 +0200
  Re: [PATCH 5/5] staging: lustre: osc: drop trivially useless  initialization Julia Lawall <julia.lawall@lip6.fr> - 2015-06-21 02:50 +0200

csiph-web