Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1168603

Re: [PATCH v2 2/5] extcon: arizona: Add basic microphone detection DT/ACPI bindings

Show all headers | View raw

On Fri, Jun 19, 2015 at 11:25:57AM +0900, Chanwoo Choi wrote:
> Hi Charles,
> 
> On Thu, Jun 18, 2015 at 11:43 PM, Charles Keepax
> <ckeepax@opensource.wolfsonmicro.com> wrote:
> > This patch adds bindings for the basic microphone detection platform
> > data.
> >
> > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> > ---
> > +       dbtime = 0;
> > +       device_property_read_u32(arizona->dev, "wlf,micd-dbtime", &dbtime);
> > +       switch (dbtime) {
> > +       case 2:
> 
> I'd like you to define the constant variable for specific integer
> value to improve the readability.
> e.g.,
> 
> #define MICD_DBTIME_XXX 2
> #define MICD_DBTIME_XXX 4
> 
> > +               pdata->micd_dbtime = 0x10000;
> 
> Also, you better to define the constant variable for "0x10000" to
> improbe readability in the include/linux/mfd/arizona.h. If you just
> use the hex value, the other developer cannot analyze the meaning of
> "0x10000".
> 
> > +               break;
> > +       case 4:
> 
> ditto.
> 

I am not sure these two really warrant a define the number in DT
indicates the number of debounces to perform.

#define MICD_DBTIME_TWO 2

switch (dbtime)
case MICD_DBTIME_TWO:

Is if anything less clear than just using 2 directly. I could
perhaps rename the varible to num_debounces instead?

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/5] extcon: arizona: Add basic microphone detection  DT/ACPI bindings Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-06-19 10:20 +0200
  Re: [PATCH v2 2/5] extcon: arizona: Add basic microphone detection  DT/ACPI bindings Chanwoo Choi <cwchoi00@gmail.com> - 2015-06-19 10:30 +0200
    Re: [PATCH v2 2/5] extcon: arizona: Add basic microphone detection  DT/ACPI bindings Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-06-19 11:10 +0200

csiph-web