Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1166456
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format |
| Date | 2015-06-17 00:30 +0200 |
| Message-ID | <pC7wK-7uK-29@gated-at.bofh.it> (permalink) |
| References | <pC4yS-3dz-17@gated-at.bofh.it> <pC4yT-3dz-41@gated-at.bofh.it> <pC5lg-4rn-21@gated-at.bofh.it> <pC7dn-787-1@gated-at.bofh.it> |
| Organization | Cogent Embedded |
Hello.
On 06/17/2015 01:09 AM, Joe Perches wrote:
>>> Append 0x to all %x in order to avoid while reading when there is other
>>> decimal value in the log.
> []
>>> @@ -874,7 +874,7 @@ static inline void xenvif_grant_handle_set(struct xenvif_queue *queue,
>>> if (unlikely(queue->grant_tx_handle[pending_idx] !=
>>> NETBACK_INVALID_HANDLE)) {
>>> netdev_err(queue->vif->dev,
>>> - "Trying to overwrite active handle! pending_idx: %x\n",
>>> + "Trying to overwrite active handle! pending_idx: 0x%x\n",
>> Using "%#x" is shorter ind does the same.
> That's true, but it's also far less common.
Which is a pity... People just don't know the format specifiers well
enough. :-(
> $ git grep -E "%#[\*\d\.]*x" | wc -l
> 1419
> $ git grep "0x%" | wc -l
> 29844
Which means 29 KB could theoretically be saved on allyesconfig build. :-)
(Actually less since the width specifiers will likely need to be fixed where
present.)
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 0/3] net/xen: Clean up Julien Grall <julien.grall@citrix.com> - 2015-06-16 21:20 +0200
[PATCH v4 2/3] net/xen-netback: Remove unused code in xenvif_rx_action Julien Grall <julien.grall@citrix.com> - 2015-06-16 21:20 +0200
Re: [PATCH v4 2/3] net/xen-netback: Remove unused code in xenvif_rx_action David Miller <davem@davemloft.net> - 2015-06-21 18:40 +0200
[PATCH v4 1/3] net/xen-netfront: Correct printf format in xennet_get_responses Julien Grall <julien.grall@citrix.com> - 2015-06-16 21:20 +0200
Re: [PATCH v4 1/3] net/xen-netfront: Correct printf format in xennet_get_responses David Miller <davem@davemloft.net> - 2015-06-21 18:40 +0200
[PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format Julien Grall <julien.grall@citrix.com> - 2015-06-16 21:20 +0200
Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-06-16 22:10 +0200
Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format Joe Perches <joe@perches.com> - 2015-06-17 00:10 +0200
Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-06-17 00:30 +0200
Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format Joe Perches <joe@perches.com> - 2015-06-17 02:00 +0200
Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format David Miller <davem@davemloft.net> - 2015-06-21 18:40 +0200
csiph-web