Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1166331

[PATCH v4 2/3] net/xen-netback: Remove unused code in xenvif_rx_action

Show all headers | View raw

The variables old_req_cons and ring_slots_used are assigned but never
used since commit 1650d5455bd2dc6b5ee134bd6fc1a3236c266b5b "xen-netback:
always fully coalesce guest Rx packets".

Signed-off-by: Julien Grall <julien.grall@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: netdev@vger.kernel.org

---
    Changes in v2:
        - Add Wei's Acked-by
---
 drivers/net/xen-netback/netback.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index 0d25943..ba3ae30 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -515,14 +515,9 @@ static void xenvif_rx_action(struct xenvif_queue *queue)
 
 	while (xenvif_rx_ring_slots_available(queue, XEN_NETBK_RX_SLOTS_MAX)
 	       && (skb = xenvif_rx_dequeue(queue)) != NULL) {
-		RING_IDX old_req_cons;
-		RING_IDX ring_slots_used;
-
 		queue->last_rx_time = jiffies;
 
-		old_req_cons = queue->rx.req_cons;
 		XENVIF_RX_CB(skb)->meta_slots_used = xenvif_gop_skb(skb, &npo, queue);
-		ring_slots_used = queue->rx.req_cons - old_req_cons;
 
 		__skb_queue_tail(&rxq, skb);
 	}
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/3] net/xen: Clean up Julien Grall <julien.grall@citrix.com> - 2015-06-16 21:20 +0200
  [PATCH v4 2/3] net/xen-netback: Remove unused code in xenvif_rx_action Julien Grall <julien.grall@citrix.com> - 2015-06-16 21:20 +0200
    Re: [PATCH v4 2/3] net/xen-netback: Remove unused code in  xenvif_rx_action David Miller <davem@davemloft.net> - 2015-06-21 18:40 +0200
  [PATCH v4 1/3] net/xen-netfront: Correct printf format in xennet_get_responses Julien Grall <julien.grall@citrix.com> - 2015-06-16 21:20 +0200
    Re: [PATCH v4 1/3] net/xen-netfront: Correct printf format in  xennet_get_responses David Miller <davem@davemloft.net> - 2015-06-21 18:40 +0200
  [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format Julien Grall <julien.grall@citrix.com> - 2015-06-16 21:20 +0200
    Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with  0x in the printf format Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-06-16 22:10 +0200
      Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with  0x in the printf format Joe Perches <joe@perches.com> - 2015-06-17 00:10 +0200
        Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with  0x in the printf format Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-06-17 00:30 +0200
          Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with  0x in the printf format Joe Perches <joe@perches.com> - 2015-06-17 02:00 +0200
    Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal  with 0x in the printf format David Miller <davem@davemloft.net> - 2015-06-21 18:40 +0200

csiph-web