Re: [PATCH 09/10] x86/intel_rdt: Hot cpu support for Cache Allocation

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Vikas Shivappa <vikas.shivappa@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 09/10] x86/intel_rdt: Hot cpu support for Cache Allocation
Date	Tue, 16 Jun 2015 21:10:02 +0200
Message-ID	<pC4pc-32i-19@gated-at.bofh.it> (permalink)
References	<pABSh-5cu-3@gated-at.bofh.it> <pABSh-5cu-1@gated-at.bofh.it> <pBUSU-5Rc-53@gated-at.bofh.it>
X-Original-To	Thomas Gleixner <tglx@linutronix.de>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.13,627,1427785200"; d="scan'208";a="509342249"
X-X-Sender	vikas@vshiva-Udesk
User-Agent	Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version	1.0
Content-Type	TEXT/PLAIN; format=flowed; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	Vikas Shivappa <vikas.shivappa@linux.intel.com>, linux-kernel@vger.kernel.org, vikas.shivappa@intel.com, x86@kernel.org, hpa@zytor.com, mingo@kernel.org, peterz@infradead.org, matt.fleming@intel.com, will.auld@intel.com, linux-rdt@eclists.intel.com
X-Original-Date	Tue, 16 Jun 2015 12:01:19 -0700 (PDT)
X-Original-Message-ID	<alpine.DEB.2.10.1506161143500.32420@vshiva-Udesk>
X-Original-References	<1434133037-25189-1-git-send-email-vikas.shivappa@linux.intel.com> <1434133037-25189-10-git-send-email-vikas.shivappa@linux.intel.com> <alpine.DEB.2.11.1506161046450.4120@nanos>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1166323

Show key headers only | View raw

On Tue, 16 Jun 2015, Thomas Gleixner wrote:

> On Fri, 12 Jun 2015, Vikas Shivappa wrote:
>> +static inline void intel_rdt_cpu_start(int cpu)
>> +{
>> +	struct intel_pqr_state *state = &per_cpu(pqr_state, cpu);
>> +
>> +	state->closid = 0;
>> +	mutex_lock(&rdt_group_mutex);
>
> This is called from CPU_STARTING, which runs on the starting cpu with
> interrupts disabled. Clearly never tested with any of the mandatory
> debug configs enabled.

But this can race with cbm_update_all calling on_each_cpu_mask ? or in other 
words the lock helps on_each_cpu_mask not race with hot cpu code updating the 
rdt_cpumask since the on_each_cpu_mask is also called with the lock always.

Its tested on the 0 day build which should include the debug config. Will add a 
tested tag.

Thanks,
Vikas

>
> Thanks
>
> 	tglx
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 09/10] x86/intel_rdt: Hot cpu support for Cache  Allocation Vikas Shivappa <vikas.shivappa@intel.com> - 2015-06-16 21:10 +0200
  Re: [PATCH 09/10] x86/intel_rdt: Hot cpu support for Cache  Allocation Thomas Gleixner <tglx@linutronix.de> - 2015-06-16 21:30 +0200

csiph-web