Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1166323

Re: [PATCH 09/10] x86/intel_rdt: Hot cpu support for Cache Allocation

Show all headers | View raw

On Tue, 16 Jun 2015, Thomas Gleixner wrote:

> On Fri, 12 Jun 2015, Vikas Shivappa wrote:
>> +static inline void intel_rdt_cpu_start(int cpu)
>> +{
>> +	struct intel_pqr_state *state = &per_cpu(pqr_state, cpu);
>> +
>> +	state->closid = 0;
>> +	mutex_lock(&rdt_group_mutex);
>
> This is called from CPU_STARTING, which runs on the starting cpu with
> interrupts disabled. Clearly never tested with any of the mandatory
> debug configs enabled.

But this can race with cbm_update_all calling on_each_cpu_mask ? or in other 
words the lock helps on_each_cpu_mask not race with hot cpu code updating the 
rdt_cpumask since the on_each_cpu_mask is also called with the lock always.

Its tested on the 0 day build which should include the debug config. Will add a 
tested tag.

Thanks,
Vikas

>
> Thanks
>
> 	tglx
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 09/10] x86/intel_rdt: Hot cpu support for Cache  Allocation Vikas Shivappa <vikas.shivappa@intel.com> - 2015-06-16 21:10 +0200
  Re: [PATCH 09/10] x86/intel_rdt: Hot cpu support for Cache  Allocation Thomas Gleixner <tglx@linutronix.de> - 2015-06-16 21:30 +0200

csiph-web