Re: [PATCHv4 1/2] dts: Adding docs for Xilinx LogiCORE IP mailbox driver.

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Josh Cartwright <joshc@ni.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv4 1/2] dts: Adding docs for Xilinx LogiCORE IP mailbox driver.
Date	Tue, 16 Jun 2015 20:50:01 +0200
Message-ID	<pC45P-2oS-3@gated-at.bofh.it> (permalink)
References	<pwABs-6JE-3@gated-at.bofh.it> <pwABs-6JE-1@gated-at.bofh.it>
X-Original-To	Moritz Fischer <moritz.fischer@ettus.com>
MIME-Version	1.0
User-Agent	Mutt/1.5.23 (2014-03-12)
X-Mimetrack	Itemize by SMTP Server on US-AUS-MGWOut1/AUS/H/NIC(Release 8.5.3FP6 HF1218\|December 12, 2014) at 06/16/2015 01:45:22 PM, Serialize by Router on US-AUS-MGWOut1/AUS/H/NIC(Release 8.5.3FP6 HF1218\|December 12, 2014) at 06/16/2015 01:45:23 PM, Serialize complete at 06/16/2015 01:45:23 PM
Content-Type	multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kjpMrWxdCilgNbo1"
Content-Disposition	inline
X-Proofpoint-Virus-Version	vendor=fsecure engine=2.50.10432:,, definitions=2015-06-16_06:,, signatures=0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	71
Organization	linux.* mail to news gateway
X-Original-Cc	jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, akpm@linux-foundation.org, gregkh@linuxfoundation.org, mchehab@osg.samsung.com, arnd@arndb.de, joe@perches.com, jingoohan1@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
X-Original-Date	Tue, 16 Jun 2015 13:45:22 -0500
X-Original-Message-ID	<20150616184522.GU633@jcartwri.amer.corp.natinst.com>
X-Original-References	<1433175507-3833-1-git-send-email-moritz.fischer@ettus.com> <1433175507-3833-2-git-send-email-moritz.fischer@ettus.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1166314

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Jun 01, 2015 at 09:18:26AM -0700, Moritz Fischer wrote:
> Changes from v3:
> - Changed reg size to 0x100
> 
> Changes from v2:
> - Addressed Michal's stylistic comments
> - Fixed typo in compatible string
> 
> Changes from v1:
> - Added common clock framework support
> 
> Changes from v0:
> - Fixed example bindings
> 
> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
> ---
>  .../bindings/mailbox/xilinx-mailbox.txt         | 44 ++++++++++++++++++++
>  1 file changed, 44 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt b/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt
> new file mode 100644
> index 0000000..f9ec46d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt
> @@ -0,0 +1,44 @@
> +Xilinx Mailbox Driver
> +=====================
> +
> +Required properties:
> +- compatible       : "xlnx,mailbox-2.1".
> +- reg              :  physical base address of the mailbox and length of
> +                      memory mapped region.
> +- #mbox-cells      :  common mailbox binding property to identify the number
> +                      of cells required for the mailbox specifier, should be 1

It seems strange to me to require #mbox-cells = <1>, when this hardware
only supports a single channel.  Why not #mbox-cells = <0>; ?

  Josh

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCHv4 1/2] dts: Adding docs for Xilinx LogiCORE IP mailbox  driver. Josh Cartwright <joshc@ni.com> - 2015-06-16 20:50 +0200

csiph-web