Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Josh Cartwright Newsgroups: linux.kernel Subject: Re: [PATCHv4 1/2] dts: Adding docs for Xilinx LogiCORE IP mailbox driver. Date: Tue, 16 Jun 2015 20:50:01 +0200 Message-ID: References: X-Original-To: Moritz Fischer MIME-Version: 1.0 User-Agent: Mutt/1.5.23 (2014-03-12) X-Mimetrack: Itemize by SMTP Server on US-AUS-MGWOut1/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 06/16/2015 01:45:22 PM, Serialize by Router on US-AUS-MGWOut1/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 06/16/2015 01:45:23 PM, Serialize complete at 06/16/2015 01:45:23 PM Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kjpMrWxdCilgNbo1" Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-06-16_06:,, signatures=0 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 71 Organization: linux.* mail to news gateway X-Original-Cc: jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, akpm@linux-foundation.org, gregkh@linuxfoundation.org, mchehab@osg.samsung.com, arnd@arndb.de, joe@perches.com, jingoohan1@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Original-Date: Tue, 16 Jun 2015 13:45:22 -0500 X-Original-Message-ID: <20150616184522.GU633@jcartwri.amer.corp.natinst.com> X-Original-References: <1433175507-3833-1-git-send-email-moritz.fischer@ettus.com> <1433175507-3833-2-git-send-email-moritz.fischer@ettus.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: aioe.org linux.kernel:1166314 --kjpMrWxdCilgNbo1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 01, 2015 at 09:18:26AM -0700, Moritz Fischer wrote: > Changes from v3: > - Changed reg size to 0x100 >=20 > Changes from v2: > - Addressed Michal's stylistic comments > - Fixed typo in compatible string >=20 > Changes from v1: > - Added common clock framework support >=20 > Changes from v0: > - Fixed example bindings >=20 > Signed-off-by: Moritz Fischer > Acked-by: Michal Simek > --- > .../bindings/mailbox/xilinx-mailbox.txt | 44 ++++++++++++++++++++ > 1 file changed, 44 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt= b/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt > new file mode 100644 > index 0000000..f9ec46d > --- /dev/null > +++ b/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt > @@ -0,0 +1,44 @@ > +Xilinx Mailbox Driver > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > + > +Required properties: > +- compatible : "xlnx,mailbox-2.1". > +- reg : physical base address of the mailbox and length of > + memory mapped region. > +- #mbox-cells : common mailbox binding property to identify the nu= mber > + of cells required for the mailbox specifier, shoul= d be 1 It seems strange to me to require #mbox-cells =3D <1>, when this hardware only supports a single channel. Why not #mbox-cells =3D <0>; ? Josh --kjpMrWxdCilgNbo1 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJVgG7CAAoJEKp7ZBKwQFAr/MgH/1iYEHdVAN6IFr9IQYVywOXH JDI89vLBAEKfEZNby4k1JjBKevTj3r2pfDsTklulXBRL1jyT4vH1sN1/LmLL8RXZ avT9VYrEZOOcnUWQDFaOplsQJwNZdrjelLi4FY20MeMAWE6DNcU6hHuo7RisNUf6 N3TtRCnKRBLKDOgXFB1NDGdOiaCP+nOWu6PelxEqovVRPlczPUmIVf+4eIvU3+co hmrbzyCJlsBOCVuTAFo/0/ceCaVOINbn+Wgn/zKuzmI1ek76YSKv2UPAtlXqnBd2 jfZVJEaPso0ulOXML/+PFDP0L9ujGW4GPTp4+AitUS8MC7pw21BCtewaBvJcVUY= =JUxc -----END PGP SIGNATURE----- --kjpMrWxdCilgNbo1-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/