Re: [PATCH non-pretimeout 4/7] Watchdog: introduce ARM SBSA watchdog driver

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Fu Wei <fu.wei@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH non-pretimeout 4/7] Watchdog: introduce ARM SBSA watchdog driver
Date	Sun, 14 Jun 2015 12:20:01 +0200
Message-ID	<pBdbb-Qr-3@gated-at.bofh.it> (permalink)
References	<pqlF8-659-23@gated-at.bofh.it> <pzSit-503-9@gated-at.bofh.it> <pzSsa-5bn-3@gated-at.bofh.it> <pAoim-214-5@gated-at.bofh.it>
X-Original-To	Timur Tabi <timur@codeaurora.org>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=a0fMPwi5RBCoI23vAsQ0G14TdRdBKPb0lluoaGMOlak=; b=Ekw1ASuzwsv5PxxaOQeQZ47+C5mmG50ZUgqVUU6USTHotmFizkYo72i94ejrs4WjAH iI8XwwP9owmFXyA/3TIFwG0s9kvU4n1kzxAybe9zkhSjmKyIxZCFdRJkJcChY4vHkmeB jb6cBru+7OSbXiPSELiIl751H0HeZT4nv7znJVALu+ji4xQxYa5y8Dg8Cn3YK//DcsPj kco4ox3TrpSO3vT03NLl0SKegGg6o3NlWoCIlJXzKbXzu6+WoNXKMQKAq5fmOx6Pg1TI xi+Gd5SChv7M5gBKyU7uZyEkVQF9Udv/hQ5wSLw4gD5xwUabb+tTinrqGt5O7g44TiAs lRJg==
X-Gm-Message-State	ALoCoQl3c4DJsnFrUqordOFMdxJdh939UltevgcLE6OCk4B7AhqGHQUMX1EkoWiuTMGLiOO+PccB
MIME-Version	1.0
X-Received	by 10.60.131.147 with SMTP id om19mr19211515oeb.78.1434276957536; Sun, 14 Jun 2015 03:15:57 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	61
Organization	linux.* mail to news gateway
X-Original-Cc	Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>, Linaro ACPI Mailman List <linaro-acpi@lists.linaro.org>, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Wei Fu <tekkamanninja@gmail.com>, G Gregory <graeme.gregory@linaro.org>, Al Stone <al.stone@linaro.org>, Hanjun Guo <hanjun.guo@linaro.org>, Ashwin Chaugule <ashwin.chaugule@linaro.org>, Arnd Bergmann <arnd@arndb.de>, Guenter Roeck <linux@roeck-us.net>, Vipul Gandhi <vgandhi@codeaurora.org>, Wim Van Sebroeck <wim@iguana.be>, Jon Masters <jcm@redhat.com>, Leo Duran <leo.duran@amd.com>, Jon Corbet <corbet@lwn.net>, Mark Rutland <mark.rutland@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, rjw@rjwysocki.net
X-Original-Date	Sun, 14 Jun 2015 18:15:57 +0800
X-Original-Message-ID	<CADyBb7vRG+h-m_2YoMfu76Q_CqOVC7BafGzqaLmCkNF9QXpXHg@mail.gmail.com>
X-Original-References	<=fu.wei@linaro.org> <1433958452-23721-1-git-send-email-fu.wei@linaro.org> <1433958452-23721-5-git-send-email-fu.wei@linaro.org> <557A58A5.4010208@codeaurora.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1164808

Show key headers only | View raw

Hi Timur

On 12 June 2015 at 11:57, Timur Tabi <timur@codeaurora.org> wrote:
> fu.wei@linaro.org wrote:
>>
>> +       if (timeout <= gwdt->max_wor_timeout)
>> +               writel_relaxed(timeout * gwdt->clk,
>> +                              gwdt->control_base + SBSA_GWDT_WOR);
>> +       else
>> +               writel_relaxed(gwdt->max_wor_timeout * gwdt->clk,
>> +                              gwdt->control_base + SBSA_GWDT_WOR);
>
>
> You pre-calculate the maximum timeout possible already, so why do you need
> the if-statement?

Have took Guenter's suggestion on this.

>
> Frankly, your non-pretimeout driver is almost identical to mine, which was
> posted weeks ago.  At this point, you're really just copying my driver but
> putting your name on it.

Everyone can see how this driver become to this one gradually. For
non-pretimeout, if there is not pretimeout variable, I can only use
timeout to config both of them.
This is  definitely not the copy of yours(check yours again, you never
programme WCV, and from the comment from you , you didn't believe
driver can do that. you use panic because of my patch),  and I posted
my patchset(with pretimeout) to linaro-acpi list before you posted
yours to linux mailing list.  And I always focus on mine.

Let people judge from all these patchset, I don't want to argue with
you on this any more.

>
>
> --
> Sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the
> Code Aurora Forum, hosted by The Linux Foundation.

-- 
Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH non-pretimeout 4/7] Watchdog: introduce ARM SBSA  watchdog driver Timur Tabi <timur@codeaurora.org> - 2015-06-12 06:00 +0200
  Re: [PATCH non-pretimeout 4/7] Watchdog: introduce ARM SBSA watchdog driver Fu Wei <fu.wei@linaro.org> - 2015-06-14 12:20 +0200

csiph-web