Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1163741

Re: [PATCH v2 6/6] regulator: qcom-spmi: Add vendor specific configuration

Show all headers | View raw

On Thu, Jun 11, 2015 at 7:37 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> Add support for over current protection (OCP), pin control
> selection, soft start and soft start strength, auto-mode, input
> current limiting, and pull down.
>
> Cc: <devicetree@vger.kernel.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>
> Changes from v1:
> * New patch split from original SPMI regulator driver
>
>  .../bindings/regulator/qcom,spmi-regulator.txt     |  62 +++++
>  drivers/regulator/qcom_spmi-regulator.c            | 298 ++++++++++++++++++++-
>  2 files changed, 358 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
> index 75b4604bad07..ab01a152e930 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
> @@ -99,6 +99,68 @@ see regulator.txt - with additional custom properties described below:
>                     soft start are active all the time. 0 = Set initial mode to
>                     low power mode (LPM).
>
> +- qcom,auto-mode-enable:

Auto regulator modes are fairly common. Can't we have a common property here?

> +       Usage: optional
> +       Value type: <u32>

This can be bool. Unless we want to have a mode property with "auto"
being one possible value.

> +       Description: 1 = Enable automatic hardware selection of regulator
> +                        mode (HPM vs LPM); not available on boost type
> +                        regulators. 0 = Disable auto mode selection.
> +
> +- qcom,ocp-enable:
> +       Usage: optional
> +       Value type: <u32>
> +       Description: 1 = Allow over current protection (OCP) to be enabled for
> +                    voltage switch type regulators so that they latch off
> +                    automatically when over current is detected. OCP is
> +                    enabled when in HPM or auto mode.  0 = Disable OCP.

This seems common too.

> +
> +- qcom,ocp-max-retries:
> +       Usage: optional
> +       Value type: <u32>
> +       Description: Maximum number of times to try toggling a voltage switch
> +                    off and back on as a result of consecutive over current
> +                    events.
> +
> +- qcom,ocp-retry-delay:
> +       Usage: optional
> +       Value type: <u32>
> +       Description: Time to delay in milliseconds between each voltage switch
> +                    toggle after an over current event takes place.

These 2 are perhaps less common. I hope I don't have a device that does this. :)

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/6] SPMI regulator driver Stephen Boyd <sboyd@codeaurora.org> - 2015-06-12 02:40 +0200
  [PATCH v2 2/6] regulator: Add system_load constraint Stephen Boyd <sboyd@codeaurora.org> - 2015-06-12 02:40 +0200
  [PATCH v2 6/6] regulator: qcom-spmi: Add vendor specific configuration Stephen Boyd <sboyd@codeaurora.org> - 2015-06-12 02:40 +0200
    Re: [PATCH v2 6/6] regulator: qcom-spmi: Add vendor specific configuration Rob Herring <robherring2@gmail.com> - 2015-06-12 05:20 +0200
      Re: [PATCH v2 6/6] regulator: qcom-spmi: Add vendor specific configuration Stephen Boyd <sboyd@codeaurora.org> - 2015-06-13 01:30 +0200
  [PATCH v2 5/6] regulator: Add input current limit support Stephen Boyd <sboyd@codeaurora.org> - 2015-06-12 02:40 +0200

csiph-web