Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1164429

Re: [PATCH v2 6/6] regulator: qcom-spmi: Add vendor specific configuration

From Stephen Boyd <sboyd@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 6/6] regulator: qcom-spmi: Add vendor specific configuration
Date 2015-06-13 01:30 +0200
Message-ID <pAGyB-3E6-7@gated-at.bofh.it> (permalink)
References <pAlaN-5CK-11@gated-at.bofh.it> <pAlaO-5CK-31@gated-at.bofh.it> <pAnFE-1hj-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 06/11/2015 08:13 PM, Rob Herring wrote:
> On Thu, Jun 11, 2015 at 7:37 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> Add support for over current protection (OCP), pin control
>> selection, soft start and soft start strength, auto-mode, input
>> current limiting, and pull down.
>>
>> Cc: <devicetree@vger.kernel.org>
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>> ---
>>
>> Changes from v1:
>> * New patch split from original SPMI regulator driver
>>
>>  .../bindings/regulator/qcom,spmi-regulator.txt     |  62 +++++
>>  drivers/regulator/qcom_spmi-regulator.c            | 298 ++++++++++++++++++++-
>>  2 files changed, 358 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
>> index 75b4604bad07..ab01a152e930 100644
>> --- a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
>> +++ b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
>> @@ -99,6 +99,68 @@ see regulator.txt - with additional custom properties described below:
>>                     soft start are active all the time. 0 = Set initial mode to
>>                     low power mode (LPM).
>>
>> +- qcom,auto-mode-enable:
> Auto regulator modes are fairly common. Can't we have a common property here?

Should we use regulator-init-mode? We could make
spmi_regulator_of_map_mode() turn "2" into REGULATOR_MODE_FAST and then
use that to enable auto mode.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/6] SPMI regulator driver Stephen Boyd <sboyd@codeaurora.org> - 2015-06-12 02:40 +0200
  [PATCH v2 2/6] regulator: Add system_load constraint Stephen Boyd <sboyd@codeaurora.org> - 2015-06-12 02:40 +0200
  [PATCH v2 6/6] regulator: qcom-spmi: Add vendor specific configuration Stephen Boyd <sboyd@codeaurora.org> - 2015-06-12 02:40 +0200
    Re: [PATCH v2 6/6] regulator: qcom-spmi: Add vendor specific configuration Rob Herring <robherring2@gmail.com> - 2015-06-12 05:20 +0200
      Re: [PATCH v2 6/6] regulator: qcom-spmi: Add vendor specific configuration Stephen Boyd <sboyd@codeaurora.org> - 2015-06-13 01:30 +0200
  [PATCH v2 5/6] regulator: Add input current limit support Stephen Boyd <sboyd@codeaurora.org> - 2015-06-12 02:40 +0200

csiph-web