Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1163096

Re: [PATCH 1/1] arm/hw_breakpoint.c: Added #include <linux/kdebug.h> instead of<asm/kdebug.h>

Show all headers | View raw

On Thu, Jun 11, 2015 at 10:18:44AM +0100, Maninder Singh wrote:
> This patch fixes below checkpatch.pl warning:
> WARNING: Use #include <linux/kdebug.h> instead of <asm/kdebug.h>
> 
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Reviewed-by: Vaneet Narang <v.narang@samsung.com>
> ---
> arch/arm/kernel/hw_breakpoint.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/kernel/hw_breakpoint.c b/arch/arm/kernel/hw_breakpoint.c
> index dc7d0a9..86eef81 100644
> --- a/arch/arm/kernel/hw_breakpoint.c
> +++ b/arch/arm/kernel/hw_breakpoint.c
> @@ -35,7 +35,7 @@
> #include <asm/cputype.h>
> #include <asm/current.h>
> #include <asm/hw_breakpoint.h>
> -#include <asm/kdebug.h>
> +#include <linux/kdebug.h>
> #include <asm/traps.h>
>  /* Breakpoint currently in use for each BRP. */

afaict, we don't even need the header so we can just drop the #include
altogether. Same for arm64.

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/1] arm/hw_breakpoint.c: Added #include <linux/kdebug.h>  instead of<asm/kdebug.h> Will Deacon <will.deacon@arm.com> - 2015-06-11 11:40 +0200

csiph-web