Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #14705 > unrolled thread

review for kivy/2.1.0-1

Back to article view | Back to linux.debian.maint.python

Contents

  review for kivy/2.1.0-1 Jeroen Ploemen <jcfp@debian.org> - 2022-12-08 16:30 +0100
    Re: review for kivy/2.1.0-1 Jeroen Ploemen <jcfp@debian.org> - 2022-12-27 19:30 +0100
      Re: review for kivy/2.1.0-1 jcfp <linux@jcf.pm> - 2023-01-01 12:20 +0100
        Re: review for kivy/2.1.0-1 Vincent Cheng <vcheng@debian.org> - 2023-01-05 10:20 +0100
          Re: review for kivy/2.1.0-1 Jeroen Ploemen <jcfp@debian.org> - 2023-01-05 18:30 +0100

#14705 — review for kivy/2.1.0-1

[Multipart message — attachments visible in raw view] — view raw

hi Dean,

I reviewed the kivy package up for sponsorship in the Python team:

* There's quite a few lintian hits [1], and most of those look legit.
  Please fix the correctly identified issues, and add overrides for
  any false positives.

* In the changelog, you should mention this is a team upload;
  otherwise (with you not listed as either maintainer or uploader) it
  looks like an NMU.

* The copyright file is missing many entries, including:
doc/sources/.static/jquery.cookie.js:6: * Copyright (c) 2010 Klaus Hartl (stilbuero.de)
doc/sources/.static/jquery-effects-core-and-slide.js:4: * Copyright 2011, AUTHORS.txt (http://jqueryui.com/about)
doc/sources/.static/jquery-effects-core-and-slide.js:736: * Copyright 2001 Robert Penner
kivy/lib/kivy_endian.h:3:  Copyright (C) 1997-2018 Sam Lantinga
kivy/lib/sdl2.pxi:1:#Copyright (c) 2010-2012, Gabriel Jacobo
kivy/lib/libtess2/Source/...:** Copyright (C) [dates of first publication] Silicon Graphics, Inc.
kivy/lib/libtess2/Include/tesselator.h:3:** Copyright (C) [dates of first publication] Silicon Graphics, Inc.
kivy/tools/pep8checker/pep8.py:4:# Copyright (C) 2006-2009 Johann C. Rocholl
kivy/tools/pep8checker/pep8.py:5:# Copyright (C) 2009-2014 Florent Xicluna
kivy/tools/pep8checker/pep8.py:6:# Copyright (C) 2014-2016 Ian Lee


Once fixed, simply add the package back to the RFS list in the IRC
channel topic.


[1] https://salsa.debian.org/python-team/packages/kivy/-/jobs/3617039

[toc] | [next] | [standalone]

#14785

[Multipart message — attachments visible in raw view] — view raw

hi Dean,

thanks for making all those improvements. Only a couple of things
remaining:

* Copyright: try using standard license shortnames [1] where
  possible: Easing appears identical to BSD-3-clause; Khronos looks
  a lot like Expat.

* Rules, lintian: are the files in kivy/tools/image-testsuite somehow
  used by or called from within kivy? The readme in there talks about
  generating image test suites for kivy's imageloaders. I don't know
  whether this is something end users of kivy normally do; if not,
  probably best to not install that directory at all rather than
  appease lintian with an override and that chmod in d/rules.


[1]https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-short-name

[toc] | [prev] | [next] | [standalone]

#14791

---- On Sun, 01 Jan 2023 07:06:20 +0100 Dean Serenevy  wrote ---
 > > * Copyright: try using standard license shortnames [1] where 
 > >   possible: Easing appears identical to BSD-3-clause; Khronos looks 
 > >   a lot like Expat. 
 >  
 > You're right, the wording differed from the sample text, so I used different names, but the differences are not enough to change the license. 
 >  
 > I can change the Easing to use the BSD-3-clause short name, but I'm not sure what to do about the Khronos. The copyright file already has an "Expat" entry and according to Policy section 12.5. A "verbatim copy of its copyright and distribution license" must be included. An email in debian-legal [1] clarifies that really there should be no changes other than minor punctuation or whitespace variations. The standard Expat uses the word "Software" and the Khronos uses "Materials". 
 >  
 > If I need a verbatim copy of both licenses, don't I need to rename one of them? If I merge them, which text do I keep? 
 
I didn't do a word-for-word comparison, I usually recognise Expat because it uses some specific legalese terms. So thank you for being so precise when looking into this. If they're different enough (somewhat of an edge case here, maybe Khronos includes material that may not be universally considered "software" such as images or fonts?), you should indeed keep two entries (each with its own shortname). Maybe one Expat and the other Expat-Khronos to signal the license terms are very close but not identical?

PS: I'm using an ancient laptop while waiting for a replacement part for my normal system, so it could be a few days before I can do an upload.

[toc] | [prev] | [next] | [standalone]

#14797

Hi Dean,

Thanks for doing the heavy lifting in getting kivy/2.1.0-1 ready for
upload! I'm currently going through all of the packages that I
(co-)maintain in preparation for the upcoming freeze, and you've saved
me a ton of work here! I've pushed a few very minor changes to the
packaging, but otherwise I think this is ready for upload; if Jeroen
isn't planning on uploading kivy in the next day or so, I'd be happy
to do so myself. I also invite you to add yourself as an Uploader in
d/control if you anticipate maintaining kivy in the future.

One thing I wanted to bring up before actually uploading kivy is that
you've added a new (emacs-specific) binary package, and adding a new
binary package will force kivy to take a round-trip through the NEW
queue. While that's not usually a problem, since we're so close to the
freeze, there's a risk that ftpmasters may not be able to review it in
time before the freeze takes effect. Would you consider either merging
the contents of elpa-kivy-mode into python3-kivy, or defer adding the
new package for a subsequent upload? Thanks!

Regards,
Vincent

[toc] | [prev] | [next] | [standalone]

#14799

[Multipart message — attachments visible in raw view] — view raw

On Thu, 5 Jan 2023 01:17:40 -0800
Vincent Cheng <vcheng@debian.org> wrote:

> to the packaging, but otherwise I think this is ready for upload;
> if Jeroen isn't planning on uploading kivy in the next day or so,

My system has been resurrected, and I'm fine with the current state of
the kivy packaging as well. I do share Vincent's concerns about adding
a new binary pkg this close to the upcoming freeze though.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.maint.python

csiph-web