Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Jeroen Ploemen Newsgroups: linux.debian.maint.python Subject: Re: review for kivy/2.1.0-1 Date: Tue, 27 Dec 2022 19:30:01 +0100 Message-ID: References: X-Original-To: Dean Serenevy X-Mailbox-Line: From debian-python-request@lists.debian.org Tue Dec 27 18:22:31 2022 Old-Return-Path: X-Amavis-Spam-Status: No, score=-114.51 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001, USER_IN_DKIM_WELCOMELIST=-0.01, USER_IN_DKIM_WHITELIST=-100] autolearn=ham autolearn_force=no X-Mailer: Claws Mail 4.1.1 (GTK 3.24.20; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/P2rIR09Tg.M2eOCLT1g_.FU"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Debian-User: jcfp X-Mailing-List: archive/latest/20654 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20221227192158.061b2c5d@debian.org Approved: robomod@news.nic.it Lines: 46 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python@lists.debian.org X-Original-Date: Tue, 27 Dec 2022 19:21:58 +0100 X-Original-Message-ID: <20221227192158.061b2c5d@debian.org> X-Original-References: <20221208162757.3943faea@debian.org> <56b599e4-1ce1-48d9-c0db-bf0928d9c38f@serenevy.net> Xref: csiph.com linux.debian.maint.python:14785 --Sig_/P2rIR09Tg.M2eOCLT1g_.FU Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable hi Dean, thanks for making all those improvements. Only a couple of things remaining: * Copyright: try using standard license shortnames [1] where possible: Easing appears identical to BSD-3-clause; Khronos looks a lot like Expat. * Rules, lintian: are the files in kivy/tools/image-testsuite somehow used by or called from within kivy? The readme in there talks about generating image test suites for kivy's imageloaders. I don't know whether this is something end users of kivy normally do; if not, probably best to not install that directory at all rather than appease lintian with an override and that chmod in d/rules. [1]https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#licen= se-short-name --Sig_/P2rIR09Tg.M2eOCLT1g_.FU Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmOrN8YACgkQQoMEoXSN zHr5QBAAx1TW4Wk4tUJdjQ3/s91UHqXV3+I+RYY2HAM1CUXfYMoWN/OCBBCohq7t nyWYTeHFfsVCbD8ihMdtZovQtA38624i+u39LIg/WJaVfpAyVsnfIbQHeZm+gKXJ BbtM7f2F4ePzk4afQ9Lapj28eX97kGKj2dGfT4JaWPXgRl8T0iWlNYNtAU6cRa7C sfTXYkKz0O+zwDL4vxWSNbO7X8juAzce2NANgAE/yGWi0bpfyiQJRMbEP6aTsefU +8bVLF7+7iczsNRThYK2+bC8If9Cj/TEpGP25XmMLqwmNA6gTxly4z5mcoLwqus0 76mJ40bCYlrN35AhBuV4HdKiPUCzIFBSxiz/sWSvW22KPgCZZ1Pwr6EXZci+ApgL /kdTcvYaRwLME1rMi/kS+4OMGkWmVVCWfws5tfWN9ip2FvMIcLFJa3Br6Qf8EICs Nw+wTAusiGn5fo77lXbOwhKqrryReACFqqvaFgy++R7I2b23skERRU1rFu7OZU3+ ro/9QoJu2frVpeIOPm1YAc+xGvv2ho5HB4yl708xARlX1e3rIPJuSj4yJv4D3nG5 OSJYZhGHm3ePes9WPINsLdipPNHJ8Dcol/ygcfnSkGlWrMZAH0WnxNosWfIlswPC I+spMrE17Cx2f5qk8I83EwV65bjRjHBBXS5qEnfv4DxL3bnm8VE= =Mgf4 -----END PGP SIGNATURE----- --Sig_/P2rIR09Tg.M2eOCLT1g_.FU--