Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #13955 > unrolled thread

Should we allow Janitor to commit directly to all DPT packages?

Back to article view | Back to linux.debian.maint.python

Contents

  Should we allow Janitor to commit directly to all DPT packages? Sandro Tosi <morph@debian.org> - 2022-02-17 18:50 +0100
    Re: Should we allow Janitor to commit directly to all DPT packages? Andreas Tille <andreas@an3as.eu> - 2022-02-17 21:00 +0100
      Re: Should we allow Janitor to commit directly to all DPT packages? Sandro Tosi <morph@debian.org> - 2022-02-17 22:00 +0100
        Re: Should we allow Janitor to commit directly to all DPT packages? Nilesh Patra <nilesh@riseup.net> - 2022-02-17 22:10 +0100
          Re: Should we allow Janitor to commit directly to all DPT packages? Andreas Tille <andreas@an3as.eu> - 2022-02-19 14:30 +0100
    Re: Should we allow Janitor to commit directly to all DPT packages? Sandro Tosi <morph@debian.org> - 2022-03-29 23:50 +0200
      Re: Should we allow Janitor to commit directly to all DPT packages? stefanor@debian.org - 2022-05-24 12:40 +0200
        Re: Should we allow Janitor to commit directly to all DPT packages? Jelmer Vernooij <jelmer@debian.org> - 2022-05-24 12:50 +0200

#13955 — Should we allow Janitor to commit directly to all DPT packages?

Hello all,
the question is essentially all in the subject line, and my answer is yes.

I receive notifications for all MRs opened against DPT packages, and
Janitor's are always pretty much ready to merge as is, and so i think
we should let Janitor commit directly to the team packages.

Jelmer is in CC (not sure if he's subscribed), in case he wants to
chime in on the implication of this discussion.

Regards,
-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
Twitter: https://twitter.com/sandrotosi

[toc] | [next] | [standalone]

#13959

Hi,

Am Thu, Feb 17, 2022 at 12:39:54PM -0500 schrieb Sandro Tosi:
> I receive notifications for all MRs opened against DPT packages, and
> Janitor's are always pretty much ready to merge as is, and so i think
> we should let Janitor commit directly to the team packages.

I admit I'm hesitating a bit for different reasons.  While I agree that
direct commits are better than MRs I found several DPT packages with
very sensible changes in Git but no uploads following these.  For
instance fixing VCS fields and Maintainer name should be followed by an
according upload to make those changes visible to users and developers
of the *packages* in Debian.

In the Debian Med team for instance we do those automatic changes before
uploading a package - say when upgrading to new upstream versions or
fixing some bugs.  Than we run the Janitor scripts and other automatic
changes which is all done in routine-update.  I personally find this
workflow more convenient.  That way Debian Med team (as well as pkg-r
team) are blacklisted for Janitor to not have competing changes inside
the package.

Kind regards

     Andreas.

-- 
http://fam-tille.de

[toc] | [prev] | [next] | [standalone]

#13960

> I admit I'm hesitating a bit for different reasons.  While I agree that
> direct commits are better than MRs I found several DPT packages with
> very sensible changes in Git but no uploads following these.  For
> instance fixing VCS fields and Maintainer name should be followed by an
> according upload to make those changes visible to users and developers
> of the *packages* in Debian.
>
> In the Debian Med team for instance we do those automatic changes before
> uploading a package - say when upgrading to new upstream versions or
> fixing some bugs.  Than we run the Janitor scripts and other automatic
> changes which is all done in routine-update.  I personally find this
> workflow more convenient.  That way Debian Med team (as well as pkg-r
> team) are blacklisted for Janitor to not have competing changes inside
> the package.

thanks for bringing the perspective of how things are done in the Med
team, but it feels none of the points you mentioned nor the specific
Med team workflow apply here, or are relevant to just let Janitor
commit directly to our packages.

Regards,
-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
Twitter: https://twitter.com/sandrotosi

[toc] | [prev] | [next] | [standalone]

#13961

[Multipart message — attachments visible in raw view] — view raw

On 2/18/22 2:23 AM, Sandro Tosi wrote:
>> I admit I'm hesitating a bit for different reasons.  While I agree that
>> direct commits are better than MRs I found several DPT packages with
>> very sensible changes in Git but no uploads following these.  For
>> instance fixing VCS fields and Maintainer name should be followed by an
>> according upload to make those changes visible to users and developers
>> of the *packages* in Debian.
>>
>> In the Debian Med team for instance we do those automatic changes before
>> uploading a package - say when upgrading to new upstream versions or
>> fixing some bugs.  Than we run the Janitor scripts and other automatic
>> changes which is all done in routine-update.  I personally find this
>> workflow more convenient.  That way Debian Med team (as well as pkg-r
>> team) are blacklisted for Janitor to not have competing changes inside
>> the package.
> 
> thanks for bringing the perspective of how things are done in the Med
> team, but it feels none of the points you mentioned nor the specific
> Med team workflow apply here,

I suppose the highlight was the usage of routine-update[1] package before upload
and we could use it with DPT too.
This does similar(same?) changes as in janitor.

But that said, I agree with what you wrote:

> or are relevant to just let Janitor
> commit directly to our packages.

I vote a in for/OK for janitor to commit directly as well.

[1]: https://tracker.debian.org/pkg/routine-update

Regards,
Nilesh

[toc] | [prev] | [next] | [standalone]

#13967

Am Fri, Feb 18, 2022 at 02:31:13AM +0530 schrieb Nilesh Patra:
> On 2/18/22 2:23 AM, Sandro Tosi wrote:
> > thanks for bringing the perspective of how things are done in the Med
> > team, but it feels none of the points you mentioned nor the specific
> > Med team workflow apply here,
> 
> I suppose the highlight was the usage of routine-update[1] package before upload
> and we could use it with DPT too.

Yes.

> This does similar(same?) changes as in janitor.

I asked Jelmer what Janitor is doing and included those calls into
routine-update.
 
> But that said, I agree with what you wrote:
> 
> > or are relevant to just let Janitor
> > commit directly to our packages.
> 
> I vote a in for/OK for janitor to commit directly as well.

Just in case this was not clear from my previous mail:  I'm fine with
direct commits.

My additional point was that I consider it sensible to let those commits
follow actual uploads which I was missing for several DPT packages which
I touched by chance.

Kind regards

      Andreas.

> [1]: https://tracker.debian.org/pkg/routine-update

-- 
http://fam-tille.de

[toc] | [prev] | [next] | [standalone]

#14027

[Multipart message — attachments visible in raw view] — view raw

Piotr, Stefano, Bernd, Scott, Ondrey,
as owners of the DPT salsa team (
https://salsa.debian.org/groups/python-team/packages/-/group_members?sort=access_level_desc)
can you approve (or deny) this request, and so give access to Janitor to
directly commit to all our repos, instead of filing MRs?

thanks!

On Thu, Feb 17, 2022 at 12:39 PM Sandro Tosi <morph@debian.org> wrote:

> Hello all,
> the question is essentially all in the subject line, and my answer is yes.
>
> I receive notifications for all MRs opened against DPT packages, and
> Janitor's are always pretty much ready to merge as is, and so i think
> we should let Janitor commit directly to the team packages.
>
> Jelmer is in CC (not sure if he's subscribed), in case he wants to
> chime in on the implication of this discussion.
>
> Regards,
> --
> Sandro "morph" Tosi
> My website: http://sandrotosi.me/
> Me at Debian: http://wiki.debian.org/SandroTosi
> Twitter: https://twitter.com/sandrotosi
>


-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
Twitter: https://twitter.com/sandrotosi

[toc] | [prev] | [next] | [standalone]

#14110

Hi Sandro (2022.03.29_21:46:29_+0000)

Seeing Jelmer reminded me about this thread.

I have no objection, so count this as an approval.

I thought Janitor was already doing this, though...

SR

> Piotr, Stefano, Bernd, Scott, Ondrey,
> as owners of the DPT salsa team (
> https://salsa.debian.org/groups/python-team/packages/-/group_members?sort=access_level_desc)
> can you approve (or deny) this request, and so give access to Janitor to
> directly commit to all our repos, instead of filing MRs?
> 
> thanks!
> 
> On Thu, Feb 17, 2022 at 12:39 PM Sandro Tosi <morph@debian.org> wrote:
> 
> > Hello all,
> > the question is essentially all in the subject line, and my answer is yes.
> >
> > I receive notifications for all MRs opened against DPT packages, and
> > Janitor's are always pretty much ready to merge as is, and so i think
> > we should let Janitor commit directly to the team packages.
> >
> > Jelmer is in CC (not sure if he's subscribed), in case he wants to
> > chime in on the implication of this discussion.
> >
> > Regards,
> > --
> > Sandro "morph" Tosi
> > My website: http://sandrotosi.me/
> > Me at Debian: http://wiki.debian.org/SandroTosi
> > Twitter: https://twitter.com/sandrotosi
> >
> 
> 
> -- 
> Sandro "morph" Tosi
> My website: http://sandrotosi.me/
> Me at Debian: http://wiki.debian.org/SandroTosi
> Twitter: https://twitter.com/sandrotosi

-- 
Stefano Rivera
  http://tumbleweed.org.za/
  +1 415 683 3272

[toc] | [prev] | [next] | [standalone]

#14111

Yeah, this is already happening.

If the janitor starts making other sorts of changes in the future,
I'll check in here first rather than just enabling those.

Jelmer

On Tue, May 24, 2022 at 10:30:57AM +0000, stefanor@debian.org wrote:
> Hi Sandro (2022.03.29_21:46:29_+0000)
> 
> Seeing Jelmer reminded me about this thread.
> 
> I have no objection, so count this as an approval.
> 
> I thought Janitor was already doing this, though...
> 
> SR
> 
> > Piotr, Stefano, Bernd, Scott, Ondrey,
> > as owners of the DPT salsa team (
> > https://salsa.debian.org/groups/python-team/packages/-/group_members?sort=access_level_desc)
> > can you approve (or deny) this request, and so give access to Janitor to
> > directly commit to all our repos, instead of filing MRs?
> > 
> > thanks!
> > 
> > On Thu, Feb 17, 2022 at 12:39 PM Sandro Tosi <morph@debian.org> wrote:
> > 
> > > Hello all,
> > > the question is essentially all in the subject line, and my answer is yes.
> > >
> > > I receive notifications for all MRs opened against DPT packages, and
> > > Janitor's are always pretty much ready to merge as is, and so i think
> > > we should let Janitor commit directly to the team packages.
> > >
> > > Jelmer is in CC (not sure if he's subscribed), in case he wants to
> > > chime in on the implication of this discussion.
> > >
> > > Regards,
> > > --
> > > Sandro "morph" Tosi
> > > My website: http://sandrotosi.me/
> > > Me at Debian: http://wiki.debian.org/SandroTosi
> > > Twitter: https://twitter.com/sandrotosi
> > >
> > 
> > 
> > -- 
> > Sandro "morph" Tosi
> > My website: http://sandrotosi.me/
> > Me at Debian: http://wiki.debian.org/SandroTosi
> > Twitter: https://twitter.com/sandrotosi
> 
> -- 
> Stefano Rivera
>   http://tumbleweed.org.za/
>   +1 415 683 3272

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.maint.python

csiph-web