Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #13900 > unrolled thread

Fixing pytest-twisted ^W Updating twisted

Back to article view | Back to linux.debian.maint.python

Contents

  Fixing pytest-twisted ^W Updating twisted Carsten Schoenert <c.schoenert@t-online.de> - 2022-01-23 17:10 +0100
    Re: Fixing pytest-twisted ^W Updating twisted Gregor Riepl <onitake@gmail.com> - 2022-01-23 19:10 +0100
      Re: Fixing pytest-twisted ^W Updating twisted Carsten Schoenert <c.schoenert@t-online.de> - 2022-01-24 06:40 +0100
        Re: Fixing pytest-twisted ^W Updating twisted Carsten Schoenert <c.schoenert@t-online.de> - 2022-01-30 18:00 +0100

#13900 — Fixing pytest-twisted ^W Updating twisted

Hi,

I've came across through #1001371 which is basically

> pytest-twisted: (autopkgtest) needs update for python3.10: E {'warnings': 2} != {'warnings': 1}

https://bugs.debian.org/1001371

So far I understand the information from the bug report the real problem 
isn't a broken autopkgtest in pytest-twisted but rather a deprecation 
warning from twisted which turns into an error.

So I've looked into twisted. We currently ship a quite old version and I 
think instead of "just" fixing the current version in unstable/testing 
we should updating twisted to the most recent version in a midterm.

I've already done some work to get this done, but at least the 
autopkgtest is something I haven't got to successful working.

My current WIP can be found here:

https://salsa.debian.org/tijuca/twisted

I created a new branch debian/master on top of the current master branch 
(due to group policy) and I tried to update the patch queue (successful 
I think), a lot of old patches are not needed anymore I'd say.

I also added some new patches later while working on issues to get the 
build at least completed. I do not have a greater experience on the 
twisted framework, so currently I can't say for sure that my current WIP 
is completely right, but it should be nearly by.

Currently the autopkgtest beaks on some version comparing which I can't 
really rate.

> twisted.trial.unittest.FailTest: '[dummy, version 1.0.0rc1]' != '[dummy, version 1.0.0.rc1]'

The relevant part is visible here:

> https://salsa.debian.org/tijuca/twisted/-/jobs/2375834#L504

I tend to disable these tests for now to make progress on more relevant 
parts like updating d/rules to debhelper style. But without some help 
regarding the later required binary packages I wont get done this.

Ignoring the autopkgtest for now Lintian is complaining about empty 
binary packages for python3-twisted-{bin,dbg}. Are they needed anymore?
OTOH it's looking not that bad and a lot of the messages should be easy 
to fix.

> $ lintian -IE
> W: python3-twisted-bin: empty-binary-package
> W: python3-twisted-bin-dbg: empty-binary-package
> W: python3-twisted: no-manual-page usr/bin/cftp3
> W: python3-twisted: no-manual-page usr/bin/ckeygen3
> W: python3-twisted: no-manual-page usr/bin/conch3
> W: python3-twisted: no-manual-page ... use --no-tag-display-limit to see all (or pipe to a file/program)
> W: twisted-doc: privacy-breach-generic usr/share/doc/twisted-doc/html/_downloads/c0d415299e6995227a6e3c8a2ed17fe5/slots-attributes-output.html [<img src="http://example.com/user.png" />] (http://example.com/user.png)
> W: python3-twisted: uses-implicit-await-trigger interest (line 1)
> W: twisted-doc: zero-byte-file-in-doc-directory usr/share/doc/twisted-doc/html/api/extra.css
> X: python3-twisted: application-in-library-section python usr/bin/cftp3 usr/bin/trial3 usr/bin/conch3 usr/bin/pyhtmlizer3 usr/bin/twist3 usr/bin/mailmail3 usr/bin/twistd3 usr/bin/tkconch3 usr/bin/ckeygen3
> I: twisted source: debian-rules-parses-dpkg-parsechangelog (line 8)
> I: twisted source: duplicate-long-description python3-twisted python3-twisted-bin
> I: twisted source: duplicate-short-description python3-twisted python3-twisted-bin
> X: python3-twisted: library-package-name-for-application usr/bin/cftp3 usr/bin/trial3 usr/bin/conch3 usr/bin/pyhtmlizer3 usr/bin/twist3 usr/bin/mailmail3 usr/bin/twistd3 usr/bin/tkconch3 usr/bin/ckeygen3
> I: twisted source: no-dh-sequencer
> I: twisted source: out-of-date-standards-version 4.5.1 (released 2020-11-17) (current is 4.6.0.1)
> I: python3-twisted: package-contains-documentation-outside-usr-share-doc usr/lib/python3/dist-packages/twisted/internet/iocpreactor/notes.txt
> X: python3-twisted-bin: package-contains-no-arch-dependent-files
> X: python3-twisted-bin-dbg: package-contains-no-arch-dependent-files
> I: twisted source: patch-not-forwarded-upstream debian/patches/0012-Skip-test-for-empty-cypher-string-openssl-does-not-t.patch
> I: twisted source: patch-not-forwarded-upstream debian/patches/Privacy-Don-t-sideload-Google-Analytics.patch
> I: twisted source: patch-not-forwarded-upstream debian/patches/WIP-Ignore-test_listingModulesAlreadyImport.patch
> I: twisted source: patch-not-forwarded-upstream ... use --no-tag-display-limit to see all (or pipe to a file/program)
> I: twisted source: upstream-metadata-missing-bug-tracking

I'm happy to hear some feedback how to proceed with the twisted framework.
I wanted to "clean" up the patch queue by uniform patch names e.g. and 
extend commit messages, but for now it's better to keep the old patches 
as changes are easier to track by this currently.

-- 
Regards
Carsten

[toc] | [next] | [standalone]

#13901

> Ignoring the autopkgtest for now Lintian is complaining about empty
> binary packages for python3-twisted-{bin,dbg}. Are they needed anymore?
> OTOH it's looking not that bad and a lot of the messages should be easy
> to fix.

> X: python3-twisted: library-package-name-for-application usr/bin/cftp3
usr/bin/trial3 usr/bin/conch3 usr/bin/pyhtmlizer3 usr/bin/twist3
usr/bin/mailmail3 usr/bin/twistd3 usr/bin/tkconch3 usr/bin/ckeygen3

Sounds to me like these binaries should go into the python3-twisted-bin
package, and that it shouldn't be empty after all.

Maybe you're missing a python3-twisted-bin.install file?

[toc] | [prev] | [next] | [standalone]

#13902

Hello Gregor,

Am 23.01.22 um 19:01 schrieb Gregor Riepl:
> 
>> Ignoring the autopkgtest for now Lintian is complaining about empty
>> binary packages for python3-twisted-{bin,dbg}. Are they needed anymore?
>> OTOH it's looking not that bad and a lot of the messages should be easy
>> to fix.
> 
>> X: python3-twisted: library-package-name-for-application usr/bin/cftp3 usr/bin/trial3 usr/bin/conch3 usr/bin/pyhtmlizer3 usr/bin/twist3 usr/bin/mailmail3 usr/bin/twistd3 usr/bin/tkconch3 usr/bin/ckeygen3
> 
> Sounds to me like these binaries should go into the python3-twisted-bin
> package, and that it shouldn't be empty after all.
> 
> Maybe you're missing a python3-twisted-bin.install file?

currently there isn't such an sequencer file. The moving of files was 
done directly within debian/rules.

The currently existing -bin package has some libraries included which 
seems to be used only for some tests.

https://packages.debian.org/bookworm/amd64/python3-twisted-bin/filelist

These SO files are not build anymore and have moved into a new own project.

https://github.com/twisted/cython-test-exception-raiser

So I think I can answer my original question by  myself. These two 
packages are not relevant and not needed any more. But thanks for your 
feedback!

-- 
Regards
Carsten

[toc] | [prev] | [next] | [standalone]

#13907

Hi again,

Am 24.01.22 um 06:35 schrieb Carsten Schoenert:
...
> So I think I can answer my original question by  myself. These two
> packages are not relevant and not needed any more. But thanks for your
> feedback!

I moved along and worked further on tuning the packaging for twisted.

I'm able to build new binary packages for the latest release of 21.7.0 
and also can run the autopkgtest at the end successful. Again I've 
pushed all to

https://salsa.debian.org/tijuca/twisted

Also the Lintian issues are down to an amount of minimum compared to the 
output for 20.3.0.
https://lintian.debian.org/sources/twisted

> $ lintian -IE --pedantic
> W: python3-twisted: no-manual-page usr/bin/cftp3
> W: python3-twisted: no-manual-page usr/bin/ckeygen3
> W: python3-twisted: no-manual-page usr/bin/conch3
> W: python3-twisted: no-manual-page ... use --no-tag-display-limit to see all (or pipe to a file/program)
> W: twisted-doc: privacy-breach-generic usr/share/doc/twisted-doc/html/_downloads/c0d415299e6995227a6e3c8a2ed17fe5/slots-attributes-output.html [<img src="http://example.com/user.png" />] (http://example.com/user.png)
> W: python3-twisted: uses-implicit-await-trigger interest (line 1)
> W: twisted-doc: zero-byte-file-in-doc-directory usr/share/doc/twisted-doc/html/api/extra.css
> X: python3-twisted: application-in-library-section python usr/bin/twistd3 usr/bin/twist3 usr/bin/cftp3 usr/bin/pyhtmlizer3 usr/bin/trial3 usr/bin/conch3 usr/bin/mailmail3 usr/bin/ckeygen3 usr/bin/tkconch3
> X: python3-twisted: library-package-name-for-application usr/bin/twistd3 usr/bin/twist3 usr/bin/cftp3 usr/bin/pyhtmlizer3 usr/bin/trial3 usr/bin/conch3 usr/bin/mailmail3 usr/bin/ckeygen3 usr/bin/tkconch3
> X: twisted source: debian-watch-does-not-check-gpg-signature
> X: twisted-doc: duplicate-files usr/share/doc/twisted-doc/development/index.rst usr/share/doc/twisted-doc/html/_sources/core/development/index.rst.txt
> X: twisted-doc: duplicate-files usr/share/doc/twisted-doc/development/listings/new_module_template.py usr/share/doc/twisted-doc/html/_downloads/4ba91eba2b7dc02d171b2b303f7cae54/new_module_template.py
> X: twisted-doc: duplicate-files usr/share/doc/twisted-doc/development/naming.rst usr/share/doc/twisted-doc/html/_sources/core/development/naming.rst.txt
> X: twisted-doc: duplicate-files ... use --no-tag-display-limit to see all (or pipe to a file/program)
> P: twisted-doc: example-unusual-interpreter python [usr/share/doc/twisted-doc/examples/courier.py]
> P: twisted-doc: example-unusual-interpreter python [usr/share/doc/twisted-doc/examples/dbcred.py]
> P: twisted-doc: example-unusual-interpreter python [usr/share/doc/twisted-doc/examples/echoclient.py]
> P: twisted-doc: example-unusual-interpreter ... use --no-tag-display-limit to see all (or pipe to a file/program)
> P: python3-twisted: executable-in-usr-lib usr/lib/python3/dist-packages/twisted/mail/test/pop3testserver.py
> P: python3-twisted: executable-in-usr-lib usr/lib/python3/dist-packages/twisted/trial/test/scripttest.py
> P: twisted-doc: repeated-path-segment finger usr/share/doc/twisted-doc/howto/tutorial/listings/finger/finger/
> P: twisted source: very-long-line-length-in-source-file NEWS.rst line 196 is 1030 characters long (>512)
> P: twisted source: very-long-line-length-in-source-file docs/core/howto/amp.rst line 183 is 535 characters long (>512)
> P: twisted source: very-long-line-length-in-source-file docs/core/howto/defer.rst line 501 is 702 characters long (>512)
> P: twisted source: very-long-line-length-in-source-file ... use --no-tag-display-limit to see all (or pipe to a file/program)


The original issue because I was looking into twisted isn't fixed yet, 
the used upstream version hasn't fixed the deprecation warning for 
currentThread().
But a new main upstream version 22.1.0 is in preparation, that will come 
with a merged in PR to fix this.

https://github.com/twisted/twisted/pull/1671

Besides this I think I'm mostly ready to give the current state a try 
and upload the modifications to unstable.

Still I'm happy to hear other minds about updating twisted before going 
further.

-- 
Regards
Carsten

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.maint.python

csiph-web