Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #13900

Fixing pytest-twisted ^W Updating twisted

Show all headers | View raw

Hi,

I've came across through #1001371 which is basically

> pytest-twisted: (autopkgtest) needs update for python3.10: E {'warnings': 2} != {'warnings': 1}

https://bugs.debian.org/1001371

So far I understand the information from the bug report the real problem 
isn't a broken autopkgtest in pytest-twisted but rather a deprecation 
warning from twisted which turns into an error.

So I've looked into twisted. We currently ship a quite old version and I 
think instead of "just" fixing the current version in unstable/testing 
we should updating twisted to the most recent version in a midterm.

I've already done some work to get this done, but at least the 
autopkgtest is something I haven't got to successful working.

My current WIP can be found here:

https://salsa.debian.org/tijuca/twisted

I created a new branch debian/master on top of the current master branch 
(due to group policy) and I tried to update the patch queue (successful 
I think), a lot of old patches are not needed anymore I'd say.

I also added some new patches later while working on issues to get the 
build at least completed. I do not have a greater experience on the 
twisted framework, so currently I can't say for sure that my current WIP 
is completely right, but it should be nearly by.

Currently the autopkgtest beaks on some version comparing which I can't 
really rate.

> twisted.trial.unittest.FailTest: '[dummy, version 1.0.0rc1]' != '[dummy, version 1.0.0.rc1]'

The relevant part is visible here:

> https://salsa.debian.org/tijuca/twisted/-/jobs/2375834#L504

I tend to disable these tests for now to make progress on more relevant 
parts like updating d/rules to debhelper style. But without some help 
regarding the later required binary packages I wont get done this.

Ignoring the autopkgtest for now Lintian is complaining about empty 
binary packages for python3-twisted-{bin,dbg}. Are they needed anymore?
OTOH it's looking not that bad and a lot of the messages should be easy 
to fix.

> $ lintian -IE
> W: python3-twisted-bin: empty-binary-package
> W: python3-twisted-bin-dbg: empty-binary-package
> W: python3-twisted: no-manual-page usr/bin/cftp3
> W: python3-twisted: no-manual-page usr/bin/ckeygen3
> W: python3-twisted: no-manual-page usr/bin/conch3
> W: python3-twisted: no-manual-page ... use --no-tag-display-limit to see all (or pipe to a file/program)
> W: twisted-doc: privacy-breach-generic usr/share/doc/twisted-doc/html/_downloads/c0d415299e6995227a6e3c8a2ed17fe5/slots-attributes-output.html [<img src="http://example.com/user.png" />] (http://example.com/user.png)
> W: python3-twisted: uses-implicit-await-trigger interest (line 1)
> W: twisted-doc: zero-byte-file-in-doc-directory usr/share/doc/twisted-doc/html/api/extra.css
> X: python3-twisted: application-in-library-section python usr/bin/cftp3 usr/bin/trial3 usr/bin/conch3 usr/bin/pyhtmlizer3 usr/bin/twist3 usr/bin/mailmail3 usr/bin/twistd3 usr/bin/tkconch3 usr/bin/ckeygen3
> I: twisted source: debian-rules-parses-dpkg-parsechangelog (line 8)
> I: twisted source: duplicate-long-description python3-twisted python3-twisted-bin
> I: twisted source: duplicate-short-description python3-twisted python3-twisted-bin
> X: python3-twisted: library-package-name-for-application usr/bin/cftp3 usr/bin/trial3 usr/bin/conch3 usr/bin/pyhtmlizer3 usr/bin/twist3 usr/bin/mailmail3 usr/bin/twistd3 usr/bin/tkconch3 usr/bin/ckeygen3
> I: twisted source: no-dh-sequencer
> I: twisted source: out-of-date-standards-version 4.5.1 (released 2020-11-17) (current is 4.6.0.1)
> I: python3-twisted: package-contains-documentation-outside-usr-share-doc usr/lib/python3/dist-packages/twisted/internet/iocpreactor/notes.txt
> X: python3-twisted-bin: package-contains-no-arch-dependent-files
> X: python3-twisted-bin-dbg: package-contains-no-arch-dependent-files
> I: twisted source: patch-not-forwarded-upstream debian/patches/0012-Skip-test-for-empty-cypher-string-openssl-does-not-t.patch
> I: twisted source: patch-not-forwarded-upstream debian/patches/Privacy-Don-t-sideload-Google-Analytics.patch
> I: twisted source: patch-not-forwarded-upstream debian/patches/WIP-Ignore-test_listingModulesAlreadyImport.patch
> I: twisted source: patch-not-forwarded-upstream ... use --no-tag-display-limit to see all (or pipe to a file/program)
> I: twisted source: upstream-metadata-missing-bug-tracking

I'm happy to hear some feedback how to proceed with the twisted framework.
I wanted to "clean" up the patch queue by uniform patch names e.g. and 
extend commit messages, but for now it's better to keep the old patches 
as changes are easier to track by this currently.

-- 
Regards
Carsten

Back to linux.debian.maint.python | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Fixing pytest-twisted ^W Updating twisted Carsten Schoenert <c.schoenert@t-online.de> - 2022-01-23 17:10 +0100
  Re: Fixing pytest-twisted ^W Updating twisted Gregor Riepl <onitake@gmail.com> - 2022-01-23 19:10 +0100
    Re: Fixing pytest-twisted ^W Updating twisted Carsten Schoenert <c.schoenert@t-online.de> - 2022-01-24 06:40 +0100
      Re: Fixing pytest-twisted ^W Updating twisted Carsten Schoenert <c.schoenert@t-online.de> - 2022-01-30 18:00 +0100

csiph-web