Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.maint.python > #8656

Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping extension causes network access during package builds

Path csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Thomas Goirand <zigo@debian.org>
Newsgroups linux.debian.maint.python
Subject Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping extension causes network access during package builds
Date Tue, 12 Jul 2016 16:10:02 +0200
Message-ID <rU6xQ-5Z5-19@gated-at.bofh.it> (permalink)
References <rSco2-3Zm-11@gated-at.bofh.it> <rSnjr-2Pm-9@gated-at.bofh.it> <rTbSV-29e-5@gated-at.bofh.it>
X-Original-To debian-python@lists.debian.org
X-Mailbox-Line From debian-python-request@lists.debian.org Tue Jul 12 14:07:45 2016
Old-Return-Path <zigo@debian.org>
X-Amavis-Spam-Status No, score=-7 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, LDO_WHITELIST=-5, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham autolearn_force=no
X-Policyd-Weight using cached result; rate: -5
X-Enigmail-Draft-Status N1110
Organization Debian
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0
MIME-Version 1.0
Content-Type text/plain; charset=windows-1252
Content-Transfer-Encoding quoted-printable
X-Mailing-List <debian-python@lists.debian.org> archive/latest/13994
List-ID <debian-python.lists.debian.org>
List-URL <https://lists.debian.org/debian-python/>
List-Archive https://lists.debian.org/msgid-search/cf87f413-4eaa-25bc-d293-4a6dae066507@debian.org
Approved robomod@news.nic.it
Lines 45
Sender robomod@news.nic.it
X-Original-Date Tue, 12 Jul 2016 16:07:15 +0200
X-Original-Message-ID <cf87f413-4eaa-25bc-d293-4a6dae066507@debian.org>
X-Original-References <1467878033.2235446.659246769.7769F4C6@webmail.messagingengine.com> <20160707193017.GA9300@mitya57.me> <8737nitgw2.fsf@prune.linuxpenguins.xyz>
Xref csiph.com linux.debian.maint.python:8656

Show key headers only | View raw


On 07/10/2016 03:34 AM, Brian May wrote:
> Moved to debian-python list from bug report.
> 
> Dmitry Shachnev <mitya57@debian.org> writes:
> 
>> You say that we can read some flag set by dh-python. However, dh-python
>> (aka pybuild) already sets http{,s}_proxy environment variables which
>> disable network access for Sphinx. So packages using dh-python are already
>> safe.
> 
> Not sure I understand how dh-python / pybuild help with this problem.

It doesn't, it simply hides the issue.

Also, sometimes exporting http{s,}_proxy simply breaks unit testing (I
did have such case, yes...). So that's not really a fit-all solution either.

> I thought the recommended way to deal with building documentation was
> something like this in debian/rules:
> 
> override_dh_auto_build:
>         dh_auto_build
>         PYTHONPATH=. sphinx-build -b html -N Doc/ Doc/.build/html

I find this not the top-noch way. Here's what I do:

override_dh_sphinxdoc:
ifeq (,$(findstring nodocs, $(DEB_BUILD_OPTIONS)))
	PYTHONPATH=. sphinx-build -b html doc/source \
		debian/python-foo-doc/usr/share/doc/python-foo-doc/html
	dh_sphinxdoc
endif

IMO, that's better because you don't need to clean Doc/.build/html.
Also, the dh_auto_build isn't the correct target. Some derivative may
well choose not to implement dh_sphinxdoc (for example, for small
systems where they don't want docs), and here, you're making their lives
miserable.

Cheers,

Thomas Goirand (zigo)

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping extension causes network access during package builds Brian May <bam@debian.org> - 2016-07-10 03:40 +0200
  Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping extension causes network access during package builds Daniele Tricoli <eriol@mornie.org> - 2016-07-10 04:00 +0200
  Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping  extension causes network access during package builds Dmitry Shachnev <mitya57@debian.org> - 2016-07-11 20:10 +0200
    Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping extension causes network access during package builds Daniele Tricoli <eriol@mornie.org> - 2016-07-11 20:30 +0200
    Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping extension causes network access during package builds Brian May <bam@debian.org> - 2016-07-11 23:50 +0200
      Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping  extension causes network access during package builds Dmitry Shachnev <mitya57@debian.org> - 2016-07-12 00:10 +0200
        Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping extension causes network access during package builds Brian May <bam@debian.org> - 2016-07-17 03:50 +0200
          Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping extension causes network access during package builds Dmitry Shachnev <mitya57@debian.org> - 2016-07-18 10:30 +0200
  Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping  extension causes network access during package builds Thomas Goirand <zigo@debian.org> - 2016-07-12 16:10 +0200
    Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping  extension causes network access during package builds Barry Warsaw <barry@python.org> - 2016-07-12 17:20 +0200
  Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping  extension causes network access during package builds Andreas Tille <andreas@an3as.eu> - 2016-07-14 13:30 +0200
    Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping extension causes network access during package builds Sergio Durigan Junior <sergiodj@sergiodj.net> - 2016-07-14 13:40 +0200
    Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping  extension causes network access during package builds Piotr Ożarowski <piotr@debian.org> - 2016-07-14 14:00 +0200

csiph-web