Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #8656

Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping extension causes network access during package builds

Show all headers | View raw

On 07/10/2016 03:34 AM, Brian May wrote:
> Moved to debian-python list from bug report.
> 
> Dmitry Shachnev <mitya57@debian.org> writes:
> 
>> You say that we can read some flag set by dh-python. However, dh-python
>> (aka pybuild) already sets http{,s}_proxy environment variables which
>> disable network access for Sphinx. So packages using dh-python are already
>> safe.
> 
> Not sure I understand how dh-python / pybuild help with this problem.

It doesn't, it simply hides the issue.

Also, sometimes exporting http{s,}_proxy simply breaks unit testing (I
did have such case, yes...). So that's not really a fit-all solution either.

> I thought the recommended way to deal with building documentation was
> something like this in debian/rules:
> 
> override_dh_auto_build:
>         dh_auto_build
>         PYTHONPATH=. sphinx-build -b html -N Doc/ Doc/.build/html

I find this not the top-noch way. Here's what I do:

override_dh_sphinxdoc:
ifeq (,$(findstring nodocs, $(DEB_BUILD_OPTIONS)))
	PYTHONPATH=. sphinx-build -b html doc/source \
		debian/python-foo-doc/usr/share/doc/python-foo-doc/html
	dh_sphinxdoc
endif

IMO, that's better because you don't need to clean Doc/.build/html.
Also, the dh_auto_build isn't the correct target. Some derivative may
well choose not to implement dh_sphinxdoc (for example, for small
systems where they don't want docs), and here, you're making their lives
miserable.

Cheers,

Thomas Goirand (zigo)

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping extension causes network access during package builds Brian May <bam@debian.org> - 2016-07-10 03:40 +0200
  Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping extension causes network access during package builds Daniele Tricoli <eriol@mornie.org> - 2016-07-10 04:00 +0200
  Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping  extension causes network access during package builds Dmitry Shachnev <mitya57@debian.org> - 2016-07-11 20:10 +0200
    Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping extension causes network access during package builds Daniele Tricoli <eriol@mornie.org> - 2016-07-11 20:30 +0200
    Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping extension causes network access during package builds Brian May <bam@debian.org> - 2016-07-11 23:50 +0200
      Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping  extension causes network access during package builds Dmitry Shachnev <mitya57@debian.org> - 2016-07-12 00:10 +0200
        Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping extension causes network access during package builds Brian May <bam@debian.org> - 2016-07-17 03:50 +0200
          Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping extension causes network access during package builds Dmitry Shachnev <mitya57@debian.org> - 2016-07-18 10:30 +0200
  Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping  extension causes network access during package builds Thomas Goirand <zigo@debian.org> - 2016-07-12 16:10 +0200
    Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping  extension causes network access during package builds Barry Warsaw <barry@python.org> - 2016-07-12 17:20 +0200
  Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping  extension causes network access during package builds Andreas Tille <andreas@an3as.eu> - 2016-07-14 13:30 +0200
    Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping extension causes network access during package builds Sergio Durigan Junior <sergiodj@sergiodj.net> - 2016-07-14 13:40 +0200
    Re: [Python-modules-team] Bug#830186: sphinx: intersphinx mapping  extension causes network access during package builds Piotr Ożarowski <piotr@debian.org> - 2016-07-14 14:00 +0200

csiph-web