Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.maint.python > #14603

Re: review for gtg/0.6-1

Path csiph.com!news.samoylyk.net!usenet.goja.nl.eu.org!aioe.org!bofh.it!news.nic.it!robomod
From François Mazen <francois@mzf.fr>
Newsgroups linux.debian.maint.python
Subject Re: review for gtg/0.6-1
Date Fri, 04 Nov 2022 17:10:02 +0100
Message-ID <Fo7qy-1mNX-13@gated-at.bofh.it> (permalink)
References <FmZ21-Fj4-3@gated-at.bofh.it>
X-Original-To Jeroen Ploemen <jcfp@debian.org>
X-Mailbox-Line From debian-python-request@lists.debian.org Fri Nov 4 16:03:24 2022
Old-Return-Path <francois@mzf.fr>
X-Amavis-Spam-Status No, score=-11.363 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_NONE=-0.0001, SARE_MSGID_LONG40=0.637] autolearn=ham autolearn_force=no
X-Policyd-Weight using cached result; rate: -5.5
X-Greylist delayed 3295 seconds by postgrey-1.36 at bendel; Fri, 04 Nov 2022 16:03:06 UTC
Authentication-Results garm.ovh; auth=pass (GARM-103G0051a8d2fc9-65bd-43c4-9c38-01a08805f3dd, 64F5F1DBEF50538E8FF6F984E71A9CD7F31202CF) smtp.auth=francois@mzf.fr
X-Ovh-Clientip 88.123.113.62
Content-Type multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="=-EWZgsJzBIGFaC+dG6VTR"
User-Agent Evolution 3.38.3-1
MIME-Version 1.0
X-Originating-IP [37.59.142.103]
X-Clientproxiedby DAG2EX2.mxp7.local (172.16.2.12) To DAG6EX1.mxp7.local (172.16.2.51)
X-Ovh-Tracer-Guid d1df4940-159b-4e0c-8835-5223eddd2153
X-Ovh-Tracer-ID 3087217545024063642
X-Vr-Spamstate OK
X-Vr-Spamcause gggruggvucftvghtrhhoucdtuddrgedvgedrvddugdejtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhepkffuhffvveffjghftggfgghisehgtderredtreejnecuhfhrohhmpefhrhgrnhopohhishcuofgriigvnhcuoehfrhgrnhgtohhishesmhiifhdrfhhrqeenucggtffrrghtthgvrhhnpedtgedtgfdukeeltdduuefhkefhgfeuhfevudehjeeuieduffevtdeivdehheelgfenucfkphepuddvjedrtddrtddruddpfeejrdehledrudegvddruddtfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehfrhgrnhgtohhishesmhiifhdrfhhrqedpnhgspghrtghpthhtohepuddprhgtphhtthhopehjtghfphesuggvsghirghnrdhorhhgpdguvggsihgrnhdqphihthhhohhnsehlihhsthhsrdguvggsihgrnhdrohhrghdpoffvtefjohhsthepmhhoheehvddpmhhouggvpehsmhhtphhouhht
X-Mailing-List <debian-python@lists.debian.org> archive/latest/20455
List-ID <debian-python.lists.debian.org>
List-URL <https://lists.debian.org/debian-python/>
List-Archive https://lists.debian.org/msgid-search/41b5143ec8d706ae4c0bd67d91c3a48eb842e137.camel@mzf.fr
Approved robomod@news.nic.it
Lines 62
Organization linux.* mail to news gateway
Sender robomod@news.nic.it
X-Original-Cc <debian-python@lists.debian.org>
X-Original-Date Fri, 4 Nov 2022 16:07:56 +0100
X-Original-Message-ID <41b5143ec8d706ae4c0bd67d91c3a48eb842e137.camel@mzf.fr>
X-Original-References <20221101135247.3fd5ebe0@debian.org>
Xref csiph.com linux.debian.maint.python:14603

Show key headers only | View raw


[Multipart message — attachments visible in raw view] - view raw

Hello Jeroen,

thanks for this important package review!

I've fixed most of your remarks. Here are the ones that I don't know
what to do:

> * copyright:
>  + public domain without explanation detailing exactly what exemption
>    the files in question have from default copyright restrictions.

I don't know what do you expect here. The current description contains
"No copyright is claimed". What should I add? 

> * autopkgtests:
>  + consider adding an autopkgtest based on the upstream testsuite.

The upstream provides two test datasets but no associated tests for the
installed application. Should I write them myself? (would be quite
complex as it's a graphical interface)


This was intense modifications of the package, but worth it! Thanks for
your time. The package is ready for a new round of review.

Best Regards,
François




Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

review for gtg/0.6-1 Jeroen Ploemen <jcfp@debian.org> - 2022-11-01 14:00 +0100
  Re: review for gtg/0.6-1 François Mazen <francois@mzf.fr> - 2022-11-04 17:10 +0100
    Re: review for gtg/0.6-1 Jeroen Ploemen <jcfp@debian.org> - 2022-11-07 14:40 +0100

csiph-web