Path: csiph.com!news.samoylyk.net!usenet.goja.nl.eu.org!aioe.org!bofh.it!news.nic.it!robomod From: =?ISO-8859-1?Q?Fran=E7ois?= Mazen Newsgroups: linux.debian.maint.python Subject: Re: review for gtg/0.6-1 Date: Fri, 04 Nov 2022 17:10:02 +0100 Message-ID: References: X-Original-To: Jeroen Ploemen X-Mailbox-Line: From debian-python-request@lists.debian.org Fri Nov 4 16:03:24 2022 Old-Return-Path: X-Amavis-Spam-Status: No, score=-11.363 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_NONE=-0.0001, SARE_MSGID_LONG40=0.637] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -5.5 X-Greylist: delayed 3295 seconds by postgrey-1.36 at bendel; Fri, 04 Nov 2022 16:03:06 UTC Authentication-Results: garm.ovh; auth=pass (GARM-103G0051a8d2fc9-65bd-43c4-9c38-01a08805f3dd, 64F5F1DBEF50538E8FF6F984E71A9CD7F31202CF) smtp.auth=francois@mzf.fr X-Ovh-Clientip: 88.123.113.62 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="=-EWZgsJzBIGFaC+dG6VTR" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-Originating-IP: [37.59.142.103] X-Clientproxiedby: DAG2EX2.mxp7.local (172.16.2.12) To DAG6EX1.mxp7.local (172.16.2.51) X-Ovh-Tracer-Guid: d1df4940-159b-4e0c-8835-5223eddd2153 X-Ovh-Tracer-ID: 3087217545024063642 X-Vr-Spamstate: OK X-Vr-Spamcause: gggruggvucftvghtrhhoucdtuddrgedvgedrvddugdejtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhepkffuhffvveffjghftggfgghisehgtderredtreejnecuhfhrohhmpefhrhgrnhopohhishcuofgriigvnhcuoehfrhgrnhgtohhishesmhiifhdrfhhrqeenucggtffrrghtthgvrhhnpedtgedtgfdukeeltdduuefhkefhgfeuhfevudehjeeuieduffevtdeivdehheelgfenucfkphepuddvjedrtddrtddruddpfeejrdehledrudegvddruddtfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehfrhgrnhgtohhishesmhiifhdrfhhrqedpnhgspghrtghpthhtohepuddprhgtphhtthhopehjtghfphesuggvsghirghnrdhorhhgpdguvggsihgrnhdqphihthhhohhnsehlihhsthhsrdguvggsihgrnhdrohhrghdpoffvtefjohhsthepmhhoheehvddpmhhouggvpehsmhhtphhouhht X-Mailing-List: archive/latest/20455 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/41b5143ec8d706ae4c0bd67d91c3a48eb842e137.camel@mzf.fr Approved: robomod@news.nic.it Lines: 62 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: X-Original-Date: Fri, 4 Nov 2022 16:07:56 +0100 X-Original-Message-ID: <41b5143ec8d706ae4c0bd67d91c3a48eb842e137.camel@mzf.fr> X-Original-References: <20221101135247.3fd5ebe0@debian.org> Xref: csiph.com linux.debian.maint.python:14603 --=-EWZgsJzBIGFaC+dG6VTR Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Jeroen, thanks for this important package review! I've fixed most of your remarks. Here are the ones that I don't know what to do: > * copyright: > =C2=A0+ public domain without explanation detailing exactly what exemptio= n > =C2=A0=C2=A0 the files in question have from default copyright restrictio= ns. I don't know what do you expect here. The current description contains "No copyright is claimed". What should I add?=20 > * autopkgtests: > =C2=A0+ consider adding an autopkgtest based on the upstream testsuite. The upstream provides two test datasets but no associated tests for the installed application. Should I write them myself? (would be quite complex as it's a graphical interface) This was intense modifications of the package, but worth it! Thanks for your time. The package is ready for a new round of review. Best Regards, Fran=C3=A7ois --=-EWZgsJzBIGFaC+dG6VTR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQJEBAABCgAuFiEEhqWr1v/bCgx/UFfTR5f6chw1HJ4FAmNlKswQHGZyYW5jb2lz QG16Zi5mcgAKCRBHl/pyHDUcnkfND/40YB8DS1mtAVh8vdI6RxXoJd3H6iH9CYKZ sWSyybc6cH0HBCIqr/cS86ZlSKoFVZgKoNpB8Yy14PyF102R6W8EP7nEuHt3Jlgr pLsFA791irWDmbB1aerR/pr3gQGVpQKPVsiPlNgHWWk/i2ClYjud0maN8I8xjjGS Dn1AOVrs0pVLd9+NJAQX/qhldI/1XyIdqco2qevQaB1zKoLo/revh7HkMeIa6eBX pr2CJQMoE9EBvxaMWl+8aLa6tfHFIY1YukJEE62znygNtawcc+QjpNmGFG8jCuVM J0rIn7hCl/O7Y2uVbWGKRNbBHR/qVWLJ7kGwLilFjWnzc94O+Lhn1L3Fg5o3Q3US i/LbC0SQ5+dhv8zYSazvIjepj9hON6wrkTIU8uxtWcZisezQUNn1HBtLSCL3Alkz M3MP4l6pQqh6gfvLxNptwNEs8awAllT1S+1rRNQ8ivki7AsV1oLOIPrFAjzDM3GU 1QndvyivcspogVsmOsbGNd/quFBwP5TFevUY1YAtjjHQ2s5GNO1HCrtuROdgps+s 7MdSS6SwGO3VZsRZzBJr1c3ZcP4cNEvHh+SSzDUWSfpNLifq0/YptrSpllS3BfHs vB1XicwqzBQTNHw+zCehfgEQ0BR2Z0yOoLwnnW+5r5onyp7LTdEX7dRQZVuSuc1b QFNrYaarXw== =VJ7f -----END PGP SIGNATURE----- --=-EWZgsJzBIGFaC+dG6VTR--